Updated russian translation #820

2015-11-05T22:33:35+01:00

itvexesme commented

2015-11-05 22:33:35 +01:00

(Migrated from github.com)

New translations for "unfinished". Also reviewed old translations.

PeterSurda commented

2015-11-05 22:36:25 +01:00

(Migrated from github.com)

Great. I will review it. Would you be willing to work on the translations for the new UI as well? See https://github.com/mailchuck/PyBitmessage

itvexesme commented

2015-11-06 06:57:34 +01:00

(Migrated from github.com)

Yep, I will send pull request for translation of new UI some later.

On 06 Nov 2015, at 01:36, Peter Šurda notifications@github.com wrote:

Great. I will review it. Would you be willing to work on the translations for the new UI as well? See https://github.com/mailchuck/PyBitmessage https://github.com/mailchuck/PyBitmessage
—
Reply to this email directly or view it on GitHub https://github.com/Bitmessage/PyBitmessage/pull/820#issuecomment-154200266.

Yep, I will send pull request for translation of new UI some later. > On 06 Nov 2015, at 01:36, Peter Šurda notifications@github.com wrote: > > Great. I will review it. Would you be willing to work on the translations for the new UI as well? See https://github.com/mailchuck/PyBitmessage https://github.com/mailchuck/PyBitmessage > — > Reply to this email directly or view it on GitHub https://github.com/Bitmessage/PyBitmessage/pull/820#issuecomment-154200266.

PeterSurda commented

2015-11-10 12:20:20 +01:00

(Migrated from github.com)

I reviewed it and I think it's ok, but I have some comments.

Can you PGP sign your commit?

While my Russian is not very advanced, are you sure that words like "Нотификации" and "трей" are appropriate translations? Is that consistent with the OS localisation, don't these use more native alternatives? I see that you already made some changes to make the translations more appropriate, for example you changed "Форсировать" into "принудительно", so maybe you can briefly compare what terms are used in a Russian OS localisation?

I tried to apply it onto my fork, but it failed because the line numbers changed. Can you perhaps do a pull request against https://github.com/mailchuck/PyBitmessage so that I don't have to edit it myself?

Thanks.

I reviewed it and I think it's ok, but I have some comments. Can you PGP sign your commit? While my Russian is not very advanced, are you sure that words like "Нотификации" and "трей" are appropriate translations? Is that consistent with the OS localisation, don't these use more native alternatives? I see that you already made some changes to make the translations more appropriate, for example you changed "Форсировать" into "принудительно", so maybe you can briefly compare what terms are used in a Russian OS localisation? I tried to apply it onto my fork, but it failed because the line numbers changed. Can you perhaps do a pull request against https://github.com/mailchuck/PyBitmessage so that I don't have to edit it myself? Thanks.

fanatid commented

2015-11-10 18:12:26 +01:00

(Migrated from github.com)

@PeterSurda it's a good translate
@e5faf2 👍

@PeterSurda it's a good translate @e5faf2 :+1:

PeterSurda commented

2015-11-10 18:28:04 +01:00

(Migrated from github.com)

@fanatid Thanks for the info, I missed the %1/%d, D'oh.

itvexesme commented

2015-11-10 18:30:54 +01:00

(Migrated from github.com)

Thanks for review, Kirill.

Отправлено с iPhone

10 нояб. 2015 г., в 21:12, Kirill Fomichev notifications@github.com написал(а):

@PeterSurda it's a good translate
@e5faf2

—
Reply to this email directly or view it on GitHub.

Thanks for review, Kirill. Отправлено с iPhone > 10 нояб. 2015 г., в 21:12, Kirill Fomichev notifications@github.com написал(а): > > @PeterSurda it's a good translate > @e5faf2 > > — > Reply to this email directly or view it on GitHub.

This repo is archived. You cannot comment on pull requests.

No reviewers