Remove state.shutdown or replaced with self._stopped from some of the network threads #2222

2024-05-09T17:02:37+02:00

anand-skss commented

2024-05-09 17:02:37 +02:00

(Migrated from github.com)

Removed state dependency from some of the network threads -> addrthread, announcethread, networkthread, recievequeuethread

* Removed state dependency from some of the network threads -> addrthread, announcethread, networkthread, recievequeuethread

PeterSurda (Migrated from github.com) requested changes 2024-05-10 01:23:21 +02:00

src/network/announcethread.py

PeterSurda (Migrated from github.com) commented

2024-05-10 01:22:53 +02:00

steamsInWhichIAmParticipating should be done separately from state.shutdown

`steamsInWhichIAmParticipating` should be done separately from `state.shutdown`

anand-skss (Migrated from github.com) reviewed 2024-05-10 07:52:22 +02:00

src/network/announcethread.py

anand-skss (Migrated from github.com) commented

2024-05-10 07:52:22 +02:00

separated those in two diff commits

PeterSurda (Migrated from github.com) reviewed 2024-05-10 09:26:03 +02:00

src/network/announcethread.py

PeterSurda (Migrated from github.com) commented

2024-05-10 09:26:02 +02:00

What I meant was, this PR should only deal with state.shutdown. There should be a separate PR, which removes the variable state.streamsInWhichIAmParticipating and replaces it just with pool.streams.

What I meant was, this PR should only deal with `state.shutdown`. There should be a separate PR, which removes the variable `state.streamsInWhichIAmParticipating` and replaces it just with `pool.streams`.