Minor visual changes for the Network Status connections table #2274

2025-01-14T03:39:31+01:00

PeterSurda commented

2025-01-14 03:39:31 +01:00

(Migrated from github.com)

Hi!

I disabled phantom "selection" of cells (which is actually a focus) in the connections table and made a couple of improvements for [dark] themes. One, discussed earlier in the chan, - to make text color black on bright backgrounds, and the second - removed a custom palette, replacing it with a stylesheet, which specifies background for the STableWidget as the "Button" role (or should it be "Window"?).

I recognize an intention to make the background not being white, but the chosen color may not fit some non-standard themes. This change also requires to restart the app after switching the theme.

I'd also change the peer background colors to some milder ones, e.g. "Gold" and "SeaGreen", but it's a matter of taste.

Hi! I disabled phantom "selection" of cells (which is actually a focus) in the connections table and made a couple of improvements for [dark] themes. One, discussed earlier in the chan, - to make text color black on bright backgrounds, and the second - removed a custom palette, replacing it with a stylesheet, which specifies background for the `STableWidget` as the "Button" role (or should it be "Window"?). I recognize an intention to make the background not being white, but the chosen color may not fit some non-standard themes. This change also requires to restart the app after switching the theme. I'd also change the peer background colors to some milder ones, e.g. "Gold" and "SeaGreen", but it's a matter of taste.

This repo is archived. You cannot comment on pull requests.

No reviewers