Bitmessage/PyBitmessage-2025-02-16
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Add label argument to createChan API endpoint #2104

Open
813492291816 wants to merge 1 commits from 813492291816/v0.6 into v0.6
pull from: 813492291816/v0.6
merge into: Bitmessage:v0.6
Conversation 2 Commits 1 Files Changed 1 +7 -3
813492291816 commented 2022-11-07 23:53:18 +01:00 (Migrated from github.com)
Copy Link

jsonrpclib throws errors sometimes due to the auto-generated labels that are based on the passphrases I set. Example:

(-32603, '<class 'api.APIError'>:API Error 0021: Unexpected API Failure - bad interpolation variable reference '%(793569%(4"]'')

This "%(793569%(4"]" is a substring of my label that's based on the passphrase and the error prevents any data from being received.

Because the passphrases I use are generated in a specific way, I can't just exclude certain character combinations as possibilities. Therefore, I propose adding the ability to set the label at the time of the chan creation, which will allow me to set the label to something different/safer than the passphrase.

jsonrpclib throws errors sometimes due to the auto-generated labels that are based on the passphrases I set. Example: ```(-32603, '<class 'api.APIError'>:API Error 0021: Unexpected API Failure - bad interpolation variable reference '%(793569%(4"]'')``` This "%(793569%(4"]" is a substring of my label that's based on the passphrase and the error prevents any data from being received. Because the passphrases I use are generated in a specific way, I can't just exclude certain character combinations as possibilities. Therefore, I propose adding the ability to set the label at the time of the chan creation, which will allow me to set the label to something different/safer than the passphrase.
PeterSurda commented 2022-11-09 04:42:36 +01:00 (Migrated from github.com)
Copy Link

I think this should be fixed differently.

I think this should be fixed differently.
813492291816 commented 2022-11-09 23:26:58 +01:00 (Migrated from github.com)
Copy Link

I don't know if this is an issue with jsonrpclib or bitmessage, or even how to debug it, but with regard to this PR, I see utility for a number of use cases in allowing the user to set the label of a new chan at creation.

I don't know if this is an issue with jsonrpclib or bitmessage, or even how to debug it, but with regard to this PR, I see utility for a number of use cases in allowing the user to set the label of a new chan at creation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-16#2104
No description provided.
Delete Branch "813492291816/v0.6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?