Bitmessage/PyBitmessage-2025-02-18
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Added mock code #1883

Open
kdcis wants to merge 10 commits from kdcis/mock-test into v0.6
pull from: kdcis/mock-test
merge into: Bitmessage:v0.6
Conversation 8 Commits 10 Files Changed 14 +653 -30
kdcis commented 2021-11-15 17:22:03 +01:00 (Migrated from github.com)
Copy Link

Added mock code for class_objectProcessor, class_singleWorker, inventory, connectionpool & stats

Added mock code for class_objectProcessor, class_singleWorker, inventory, connectionpool & stats
g1itch commented 2021-11-15 17:26:01 +01:00 (Migrated from github.com)
Copy Link

Wrong placement. There shouldn't be a mock package, because the end user doesn't need it. Please move into tests.

Wrong placement. There shouldn't be a `mock` package, because the end user doesn't need it. Please move into tests.
g1itch (Migrated from github.com) reviewed 2021-11-15 17:27:07 +01:00
src/mock/class_objectProcessor.py
g1itch (Migrated from github.com) commented 2021-11-15 17:27:07 +01:00

it will never happen

it will never happen
g1itch (Migrated from github.com) reviewed 2021-11-15 17:32:32 +01:00
src/mock/class_objectProcessor.py
g1itch (Migrated from github.com) commented 2021-11-15 17:32:32 +01:00

This is not a mock class because it uses sqlQuery() from helper_sql, thus depends on the sqlThread

This is not a mock class because it uses `sqlQuery()` from `helper_sql`, thus depends on the `sqlThread`
PeterSurda (Migrated from github.com) reviewed 2021-11-16 04:12:53 +01:00
src/mock/class_objectProcessor.py
PeterSurda (Migrated from github.com) commented 2021-11-16 04:12:53 +01:00

#1794 contains a test sql class (runs in-memory database and allows custom schema initialization), that will be used here as well.

#1794 contains a test sql class (runs in-memory database and allows custom schema initialization), that will be used here as well.
PeterSurda commented 2021-11-16 04:15:23 +01:00 (Migrated from github.com)
Copy Link

Wrong placement. There shouldn't be a mock package, because the end user doesn't need it. Please move into tests.

There are some technical difficulties with such an approach at the moment, needs a bit more work to fix it.

> Wrong placement. There shouldn't be a `mock` package, because the end user doesn't need it. Please move into tests. There are some technical difficulties with such an approach at the moment, needs a bit more work to fix it.
PeterSurda (Migrated from github.com) reviewed 2021-11-16 07:39:10 +01:00
src/mock/class_objectProcessor.py
PeterSurda (Migrated from github.com) commented 2021-11-16 07:39:10 +01:00

For the time being we can skip this, yes.

For the time being we can skip this, yes.
PeterSurda (Migrated from github.com) reviewed 2021-12-13 06:46:41 +01:00
src/tests/mock/bitmessagemock.py
PeterSurda (Migrated from github.com) commented 2021-12-13 06:46:41 +01:00

here it can start launching the mock threads.

here it can start launching the mock threads.
PeterSurda (Migrated from github.com) requested changes 2021-12-14 08:45:37 +01:00
src/tests/mock/class_objectProcessor.py
PeterSurda (Migrated from github.com) commented 2021-12-14 08:45:27 +01:00

25 - 41 - remove

25 - 41 - remove
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-18#1883
No description provided.
Delete Branch "kdcis/mock-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?