Bitmessage/PyBitmessage-2025-02-18
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Use bytes() on keys to be hashable in Python3 #2243

Open
kashikoibumi wants to merge 1 commits from kashikoibumi/bytes-key into v0.6
pull from: kashikoibumi/bytes-key
merge into: Bitmessage:v0.6
Conversation 0 Commits 1 Files Changed 14 +96 -77
kashikoibumi commented 2024-05-26 17:28:32 +02:00 (Migrated from github.com)
Copy Link

This patch is a preparation to migration to Python3.

Use bytes() on keys to be hashable in Python3.
Hash keys used in hashtables must be hashable.
Although it is not problem in Python2, it is a problem in Python3.
When slice or memoryview of mutable byte array is used as hash key in Python3, an exception is raised.
To resolve the problem, this patch convert hash keys to immutable bytes by using bytes() function.

This patch is a preparation to migration to Python3. Use bytes() on keys to be hashable in Python3. Hash keys used in hashtables must be hashable. Although it is not problem in Python2, it is a problem in Python3. When slice or memoryview of mutable byte array is used as hash key in Python3, an exception is raised. To resolve the problem, this patch convert hash keys to immutable bytes by using bytes() function.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-18#2243
No description provided.
Delete Branch "kashikoibumi/bytes-key"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?