Moved Multiqueue, invQueue and addrQueue to network module #2256

2024-06-23T06:56:54+02:00

anand-skss commented

2024-06-23 06:56:54 +02:00

(Migrated from github.com)

Moved Multiqueue, invQueue and addrQueue to network module

* Moved Multiqueue, invQueue and addrQueue to network module

anand-skss (Migrated from github.com) reviewed 2024-06-23 07:45:28 +02:00

src/network/addrthread.py

						
				@ -8,3 +8,3 @@

				import connectionpool

				from protocol import assembleAddrMessage

				from queues import addrQueue  # FIXME: init with queue

				from network import addrQueue  # FIXME: init with queue

anand-skss (Migrated from github.com) commented

2024-06-23 07:45:28 +02:00

Please check Fixme comment, i'm not sure whether i remove this comment or not.

PeterSurda (Migrated from github.com) approved these changes 2024-07-04 05:25:50 +02:00

PeterSurda (Migrated from github.com) left a comment

Looks ok, just next time I'd put the helper_random -> random change into a separate PR.

src/network/addrthread.py

						
				@ -8,3 +8,3 @@

				import connectionpool

				from protocol import assembleAddrMessage

				from queues import addrQueue  # FIXME: init with queue

				from network import addrQueue  # FIXME: init with queue

PeterSurda (Migrated from github.com) commented

2024-07-04 05:24:33 +02:00

I'm not sure either, let's leave it as it is.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-18#2256