Bitmessage/PyBitmessage-2025-02-20
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

New button "Blank" on tab "Send" to blank all fields (#919) #1116

Merged
g1itch merged 1 commits from ui-features into v0.6 2018-02-06 22:32:03 +01:00
Conversation 3 Commits 1 Files Changed 2 +12 -1
g1itch commented 2018-02-05 15:58:56 +01:00 (Migrated from github.com)
Copy Link

Hello!

Since new 0.6.3 release is soon (as you wrote), I decided to add also this button to current (non-refactored) code. Because I need it myself from time to time.

However I'm not sure about label: should it be "Discard" like proposed in #919 or maybe "Clear"?

Hello! Since new 0.6.3 release is soon (as you wrote), I decided to add also this button to current (non-refactored) code. Because I need it myself from time to time. However I'm not sure about label: should it be "Discard" like proposed in #919 or maybe "Clear"?
PeterSurda commented 2018-02-05 20:12:34 +01:00 (Migrated from github.com)
Copy Link

Excellent. I'm not competely sure what to put there either (in English). Also "Cancel", "Reset" or "Abandon" are possible. I'll do some research.

Excellent. I'm not competely sure what to put there either (in English). Also "Cancel", "Reset" or "Abandon" are possible. I'll do some research.
PeterSurda commented 2018-02-06 18:51:57 +01:00 (Migrated from github.com)
Copy Link

I thought about it, and I think the best solution would be to create a new temporary tab for each new composed message. The tab would have a "Cancel" button and also an x mark. This is how other email clients work now. But this would require a more significant redesign, so this PR is acceptable for now. As it's now, "Clear" or "Reset" are probably the best choices. I'll leave it up to you which one you choose.

I thought about it, and I think the best solution would be to create a new temporary tab for each new composed message. The tab would have a "Cancel" button and also an x mark. This is how other email clients work now. But this would require a more significant redesign, so this PR is acceptable for now. As it's now, "Clear" or "Reset" are probably the best choices. I'll leave it up to you which one you choose.
g1itch commented 2018-02-06 20:45:57 +01:00 (Migrated from github.com)
Copy Link

It's hard for me to imagine such number of tabs nested in each other. But when refactoring be finished it will be possible to freely experiment with ui-files. Maybe someone would design a proper forms.

I've chosen "Clear" term.

It's hard for me to imagine such number of tabs nested in each other. But when refactoring be finished it will be possible to freely experiment with ui-files. Maybe someone would design a proper forms. I've chosen "Clear" term.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
enhancement
Milestone
No items
No Milestone v0.6.3
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-20#1116
No description provided.
Delete Branch "ui-features"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?