Bitmessage/PyBitmessage-2025-02-20
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Test cases for shared.py #2201

Merged
anand-skss merged 1 commits from test_case into v0.6 2024-04-18 04:39:46 +02:00
Conversation 5 Commits 1 Files Changed 1 +152
anand-skss commented 2024-03-28 04:14:36 +01:00 (Migrated from github.com)
Copy Link
  • Test cases for shared.py
* Test cases for shared.py
PeterSurda (Migrated from github.com) requested changes 2024-04-05 01:05:24 +02:00
PeterSurda (Migrated from github.com) left a comment

one typo but otherwise ok

one typo but otherwise ok
src/tests/test_shared.py
PeterSurda (Migrated from github.com) commented 2024-04-05 01:05:10 +02:00

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`
PeterSurda (Migrated from github.com) requested changes 2024-04-13 15:20:20 +02:00
src/tests/test_shared.py
PeterSurda (Migrated from github.com) commented 2024-04-13 15:18:56 +02:00

maybe use addresses from samples

maybe use addresses from samples
PeterSurda (Migrated from github.com) commented 2024-04-13 15:20:11 +02:00

use constants

use constants
anand-skss (Migrated from github.com) reviewed 2024-04-15 04:43:55 +02:00
src/tests/test_shared.py
anand-skss (Migrated from github.com) commented 2024-04-15 04:43:55 +02:00

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.
PeterSurda (Migrated from github.com) reviewed 2024-04-16 06:16:37 +02:00
src/tests/test_shared.py
PeterSurda (Migrated from github.com) commented 2024-04-16 06:16:37 +02:00

I mean the numbers should be constants

I mean the numbers should be constants
PeterSurda (Migrated from github.com) approved these changes 2024-04-18 04:38:06 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-20#2201
No description provided.
Delete Branch "test_case"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?