fixed the app closing issue on the press of quit button #1671

2020-09-18T15:09:00+02:00

navjotcis commented

2020-09-18 15:09:00 +02:00

(Migrated from github.com)

Here when user try to quit the app then the app does not close it takes time longer than expected so I have fixed it for two cases

when the user open the app and closes it before the connection popup shows then the app does not close. It runs in a loop for n no. of times which takes sometimes 2-3 minutes or longer then it so I have added the condition with it for checking if the user presses quit then it will not go into the loop and close the app.
This case appears sometimes so here also app not close when the user tries to quit because there is condition pendingDownload() > 0 so app-only close when pendingDownload() returns 0 or less so the value of pendingDownload() method is not fixed sometimes it gives a large no. which run in the loop N no. of times so also it does not close the app until loop executes N no. of times so I have also added the condition here when the user press the quit then it does not go into the loop and close the app.

Here when user try to quit the app then the app does not close it takes time longer than expected so I have fixed it for two cases 1) when the user open the app and closes it before the connection popup shows then the app does not close. It runs in a loop for n no. of times which takes sometimes 2-3 minutes or longer then it so I have added the condition with it for checking if the user presses quit then it will not go into the loop and close the app. 2) This case appears sometimes so here also app not close when the user tries to quit because there is condition pendingDownload() > 0 so app-only close when pendingDownload() returns 0 or less so the value of pendingDownload() method is not fixed sometimes it gives a large no. which run in the loop N no. of times so also it does not close the app until loop executes N no. of times so I have also added the condition here when the user press the quit then it does not go into the loop and close the app.

PeterSurda commented

2020-10-13 14:48:46 +02:00

(Migrated from github.com)

This isn't working correctly. I know I made recommendations, but at best they were incomplete. Find a way to fix this properly.

navjotcis commented

2020-10-17 18:25:09 +02:00

(Migrated from github.com)

I have tested all the scenarios and then I have made the table for all the cases and all are passed

I have tested all the scenarios and then I have made the table for all the cases and all are passed ![image](https://user-images.githubusercontent.com/33522186/96348066-a6522300-10c3-11eb-8fe0-a04fd13c5f3e.png)

navjotcis commented

2020-10-27 19:10:44 +01:00

(Migrated from github.com)

I have changed the UI of the app closing popup and also when the user click on the Quit button I am showing a progress bar and on the press of don't quit progress bar will disappear. Fixes #1298

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-21#1671