Bitmessage/PyBitmessage-2025-02-22
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Remove state.shutdown or replaced with self._stopped from some of the network threads #2222

Merged
anand-skss merged 1 commits from test4 into v0.6 2024-05-13 04:30:16 +02:00
Conversation 4 Commits 1 Files Changed 4 +5 -8
anand-skss commented 2024-05-09 17:02:37 +02:00 (Migrated from github.com)
Copy Link
  • Removed state dependency from some of the network threads -> addrthread, announcethread, networkthread, recievequeuethread
* Removed state dependency from some of the network threads -> addrthread, announcethread, networkthread, recievequeuethread
PeterSurda (Migrated from github.com) requested changes 2024-05-10 01:23:21 +02:00
src/network/announcethread.py
PeterSurda (Migrated from github.com) commented 2024-05-10 01:22:53 +02:00

steamsInWhichIAmParticipating should be done separately from state.shutdown

`steamsInWhichIAmParticipating` should be done separately from `state.shutdown`
anand-skss (Migrated from github.com) reviewed 2024-05-10 07:52:22 +02:00
src/network/announcethread.py
anand-skss (Migrated from github.com) commented 2024-05-10 07:52:22 +02:00

separated those in two diff commits

separated those in two diff commits
PeterSurda (Migrated from github.com) reviewed 2024-05-10 09:26:03 +02:00
src/network/announcethread.py
PeterSurda (Migrated from github.com) commented 2024-05-10 09:26:02 +02:00

What I meant was, this PR should only deal with state.shutdown. There should be a separate PR, which removes the variable state.streamsInWhichIAmParticipating and replaces it just with pool.streams.

What I meant was, this PR should only deal with `state.shutdown`. There should be a separate PR, which removes the variable `state.streamsInWhichIAmParticipating` and replaces it just with `pool.streams`.
PeterSurda (Migrated from github.com) approved these changes 2024-05-13 04:11:44 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-22#2222
No description provided.
Delete Branch "test4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?