Bitmessage/PyBitmessage-2025-02-24
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

Don't use network for sending ACK #2205

Merged
PeterSurda merged 6 commits from gitea-77 into v0.6 2024-04-05 01:15:06 +02:00
Conversation 0 Commits 6 Files Changed 8 +80 -48
PeterSurda commented 2024-04-05 00:56:27 +02:00 (Migrated from github.com)
Copy Link

Hi!

After careful reading of the code I found a simple replacement for network.bmproto.BMStringParser() . Both objectProcessor and API HandleDisseminatePreEncryptedMsg handler do it by putting the payload into the inventory. To decode the object parameters I defined a corresponding function decodeObjectParameters() in the protocol.

Need to add more tests.

Hi! After careful reading of the code I found a simple replacement for `network.bmproto.BMStringParser()` . Both `objectProcessor` and API `HandleDisseminatePreEncryptedMsg` handler do it by putting the payload into the inventory. To decode the object parameters I defined a corresponding function `decodeObjectParameters()` in the `protocol`. Need to add more tests.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-24#2205
No description provided.
Delete Branch "gitea-77"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?