Bitmessage/PyBitmessage-2025-02-25
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

create separate method for each currentVersion of class_sqlThread module #1715

Open
navjotcis wants to merge 2 commits from navjotcis/bug-fixes18 into v0.6
pull from: navjotcis/bug-fixes18
merge into: Bitmessage:v0.6
Conversation 4 Commits 2 Files Changed 1 +267 -238
navjotcis commented 2021-01-13 21:46:10 +01:00 (Migrated from github.com)
Copy Link

I have created a separate method for each version of the class_sqlThread module
and also added a decorator for removing repeated code.

I have created a separate method for each version of the class_sqlThread module and also added a decorator for removing repeated code.
PeterSurda (Migrated from github.com) requested changes 2021-01-19 12:39:34 +01:00
PeterSurda (Migrated from github.com) left a comment

As discussed on Skype, rework the decorator so that it handles the current version, and auto-populates the upgrade loop.

As discussed on Skype, rework the decorator so that it handles the current version, and auto-populates the upgrade loop.
PeterSurda (Migrated from github.com) requested changes 2021-01-21 09:32:44 +01:00
src/class_sqlThread.py
@ -23,0 +25,4 @@
def db_upgrade(*args, **kwargs): # pylint: disable=unused-argument
"""upgrade the migration"""
version_dict = kwargs
PeterSurda (Migrated from github.com) commented 2021-01-21 09:30:59 +01:00

this looks weird

this looks weird
src/class_sqlThread.py
@ -29,0 +110,4 @@
"""version_three for upgrading inventory"""
self.inventory_upgrade()
@db_upgrade(versio_four=4)
PeterSurda (Migrated from github.com) commented 2021-01-21 09:31:14 +01:00

typo

typo
src/class_sqlThread.py
@ -29,0 +126,4 @@
parameters = (5,)
self.cur.execute(item, parameters)
@db_upgrade(versio_five=5)
PeterSurda (Migrated from github.com) commented 2021-01-21 09:31:24 +01:00

typo

typo
src/class_sqlThread.py
PeterSurda (Migrated from github.com) commented 2021-01-21 09:32:30 +01:00

maybe add a dummy version 1?

maybe add a dummy version 1?
g1itch commented 2021-02-02 16:03:19 +01:00 (Migrated from github.com)
Copy Link

Wouldn't it be better to tag 0.6.3.3 and declare it as last release supporting upgrade from 0.6.1 or older? I tried rewriting class_sqlThread too, but all attempts look ugly like this PR.

Wouldn't it be better to tag 0.6.3.3 and declare it as last release supporting upgrade from 0.6.1 or older? I tried rewriting `class_sqlThread` too, but all attempts look ugly like this PR.
g1itch commented 2021-05-28 15:17:06 +02:00 (Migrated from github.com)
Copy Link

This looks abandoned and superseded by #1760.

This looks abandoned and superseded by #1760.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
duplicate
refactoring
Milestone
No items
No Milestone v0.6.4
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-25#1715
No description provided.
Delete Branch "navjotcis/bug-fixes18"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?