Bitmessage/PyBitmessage-2025-02-28
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

Fix outdated exception handlers for singleWorker._getKeysForAddress() #2212

Merged
PeterSurda merged 1 commits from gitea-88 into v0.6 2024-04-14 06:23:28 +02:00
Conversation 0 Commits 1 Files Changed 1 +4 -4
PeterSurda commented 2024-04-14 05:22:53 +02:00 (Migrated from github.com)
Copy Link

Hi!

I found some incorrect exception handlers in the singleWorker after c1ca7044d2, maybe they are rebase artifacts. singleWorker._getKeysForAddress() handles those (configparser.NoSectionError, configparser.NoOptionError) turning them into the ValueError because highlevelcrypto.decodeWalletImportFormat() also rises it now.

Hi! I found some incorrect exception handlers in the `singleWorker` after c1ca7044d2, maybe they are rebase artifacts. `singleWorker._getKeysForAddress()` handles those (`configparser.NoSectionError`, `configparser.NoOptionError`) turning them into the `ValueError` because `highlevelcrypto.decodeWalletImportFormat()` also rises it now.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-28#2212
No description provided.
Delete Branch "gitea-88"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?