Bitmessage/PyBitmessage-2025-03-01
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

str(subject) may not be ascii #1191

Closed
sigoa wants to merge 1 commits from patch-1 into v0.6
pull from: patch-1
merge into: Bitmessage:v0.6
Conversation 3 Commits 1 Files Changed 1 +1 -1
sigoa commented 2018-03-26 21:38:13 +02:00 (Migrated from github.com)
Copy Link

eschew str(unicodeText) !

eschew **str(unicodeText)** !
🎉 1
PeterSurda (Migrated from github.com) requested changes 2018-03-28 08:31:20 +02:00
PeterSurda (Migrated from github.com) left a comment

It's a good attempt, unfortunately it doesn't work, the result is basically as if the decoding wasn't there at all.

Maybe you have to fix it in addMessageListItemInbox or in the MessageList_SubjectWidget constructor

It's a good attempt, unfortunately it doesn't work, the result is basically as if the decoding wasn't there at all. Maybe you have to fix it in addMessageListItemInbox or in the MessageList_SubjectWidget constructor
MahendraNG (Migrated from github.com) approved these changes 2018-03-28 15:16:31 +02:00
MahendraNG (Migrated from github.com) reviewed 2018-03-28 15:18:11 +02:00
MahendraNG (Migrated from github.com) left a comment

Yes, it doesn't work

Yes, it doesn't work
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
MahendraNG
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-03-01#1191
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?