Bitmessage/PyBitmessage-2025-03-01
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

TCPConnection.userAgent isn't initialised correctly #1703

New Issue
Closed
opened 2021-01-03 11:35:06 +01:00 by PeterSurda · 1 comment
PeterSurda commented 2021-01-03 11:35:06 +01:00 (Migrated from github.com)
Copy Link

Randomly travis brought this up:

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/default/travis_bionic/build/src/bitmessageqt/tests/main.py", line 34, in tearDown
    self.fail('Exception in the main thread: %s' % exc)
AssertionError: Exception in the main thread: TCPConnection instance has no attribute 'userAgent'

I looked and TCPConnection.userAgent isn't initialised in __init__, only later.

Randomly travis brought this up: ``` Traceback (most recent call last): File "/var/lib/buildbot/workers/default/travis_bionic/build/src/bitmessageqt/tests/main.py", line 34, in tearDown self.fail('Exception in the main thread: %s' % exc) AssertionError: Exception in the main thread: TCPConnection instance has no attribute 'userAgent' ``` I looked and `TCPConnection.userAgent` isn't initialised in `__init__`, only later.
g1itch commented 2021-02-15 14:16:18 +01:00 (Migrated from github.com)
Copy Link

It's universal tearDown fail in qt tests: https://buildbot.bitmessage.org/#/builders/22/builds/6/steps/7/logs/stdio
It may be difficult to reproduce particular exception though.

It's universal tearDown fail in qt tests: https://buildbot.bitmessage.org/#/builders/22/builds/6/steps/7/logs/stdio It may be difficult to reproduce particular exception though.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
bug
Milestone
No items
No Milestone v0.6.4
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-03-01#1703
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?