Bitmessage/PyBitmessage-2025-03-02
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

Moved dandelion runtime var from state to network->dandelion #2244

Merged
anand-skss merged 1 commits from test into v0.6 2024-05-27 10:53:26 +02:00
Conversation 2 Commits 1 Files Changed 10 +35 -32
anand-skss commented 2024-05-26 18:12:33 +02:00 (Migrated from github.com)
Copy Link
  • Moved dandelion runtime var from state to network->dandelion
* Moved dandelion runtime var from state to network->dandelion
PeterSurda (Migrated from github.com) requested changes 2024-05-27 04:27:17 +02:00
src/network/bmproto.py
PeterSurda (Migrated from github.com) commented 2024-05-27 04:26:22 +02:00

I wouldn't use dandelion_enabled because this is confusing. It's a bit difficult to come up with a good description, I think extend_dandelion_stem is the best I could do.

The dandelion functionality in Bitmessage is an implementation of the Dandelion++ proposal for Bitcoin (https://en.bitcoin.it/wiki/BIP_0156). The tx and dandeliontx network messages in Bitcoin correspond to inv and dinv commands in Bitmessage.

I wouldn't use `dandelion_enabled` because this is confusing. It's a bit difficult to come up with a good description, I think `extend_dandelion_stem` is the best I could do. The dandelion functionality in Bitmessage is an implementation of the Dandelion++ proposal for Bitcoin (https://en.bitcoin.it/wiki/BIP_0156). The `tx` and `dandeliontx` network messages in Bitcoin correspond to `inv` and `dinv` commands in Bitmessage.
PeterSurda (Migrated from github.com) approved these changes 2024-05-27 10:49:37 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-03-02#2244
No description provided.
Delete Branch "test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?