Bitmessage
/
PyBitmessage-build
3
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

Labels Milestones

Update dockerfiles for multi stage build #1

Merged
PeterSurda merged 1 commits from cis-muzahid/PyBitmessage-build:merge into master 2 years ago
Conversation 1 Commits 1 Files Changed 4
cis-muzahid commented 2 years ago

Change with pybm-build image and pybm-travis image and run container with that we can use build.sh only and container will start

Change with pybm-build image and pybm-travis image and run container with that we can use build.sh only and container will start
cis-muzahid added 5 commits 2 years ago
PeterSurda requested changes 2 years ago
Dockerfile Outdated
@ -0,0 +1,74 @@
FROM ubuntu:bionic
PeterSurda commented 2 years ago
Owner

I think this should be
FROM ubuntu:bionic AS pybm-build

I think this should be `FROM ubuntu:bionic AS pybm-build`
Dockerfile Outdated
@ -0,0 +51,4 @@
## pybm-travis
FROM pybm-build
PeterSurda commented 2 years ago
Owner

FROM pybm-build AS buildbot-test

`FROM pybm-build AS buildbot-test`
build.sh Outdated
@ -0,0 +1,17 @@
#!/bin/sh
PeterSurda commented 2 years ago
Owner

needs to be adjusted to use the new Dockerfile

needs to be adjusted to use the new `Dockerfile`
docker/bionic-buildenv.docker Outdated
@ -6,13 +6,15 @@ RUN dpkg --add-architecture i386
PeterSurda commented 2 years ago
Owner

file should be removed and if needed missing contents moved to Dockerfile

file should be removed and if needed missing contents moved to `Dockerfile`
docker/bionic-travis.docker Outdated
@ -1,10 +1,15 @@
FROM pybm-build
PeterSurda commented 2 years ago
Owner

file should be removed, missing contents moved to Dockerfile

file should be removed, missing contents moved to `Dockerfile`
PeterSurda commented 2 years ago
Owner

Also, you should squash the commits, PGP sign them and upload your PGP key to your account's settings.

Also, you should squash the commits, PGP sign them and upload your PGP key to your account's settings.
cis-muzahid added 1 commit 2 years ago
PeterSurda changed title from merge to Update dockerfiles for multi stage build 2 years ago
cis-muzahid force-pushed merge from 6d81c80b40 to 17989a1e63 2 years ago
PeterSurda approved these changes 2 years ago
PeterSurda merged commit 17989a1e63 into master 2 years ago

Reviewers

PeterSurda approved these changes 2 years ago
The pull request has been merged as 17989a1e63.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b cis-muzahid-merge master
git pull merge

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff cis-muzahid-merge
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
PeterSurda
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-build#1
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'cis-muzahid/PyBitmessage-build:merge'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes