Bitmessage
/
PyBitmessage-build
3
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

Update dockerfiles for multi stage build #1

Merged
PeterSurda merged 1 commits from cis-muzahid/PyBitmessage-build:merge into master 2021-01-14 15:40:54 +00:00
Conversation 1 Commits 1 Files Changed 4 +43 -52
cis-muzahid commented 2021-01-12 13:15:48 +00:00
Member
Copy Link

Change with pybm-build image and pybm-travis image and run container with that we can use build.sh only and container will start

Change with pybm-build image and pybm-travis image and run container with that we can use build.sh only and container will start
cis-muzahid added 5 commits 2021-01-12 13:15:48 +00:00
PeterSurda requested changes 2021-01-12 16:15:30 +00:00
Dockerfile Outdated
@ -0,0 +1,74 @@
FROM ubuntu:bionic
PeterSurda commented 2021-01-12 16:07:37 +00:00
Owner
Copy Link

I think this should be
FROM ubuntu:bionic AS pybm-build

I think this should be `FROM ubuntu:bionic AS pybm-build`
Dockerfile Outdated
@ -0,0 +51,4 @@
## pybm-travis
FROM pybm-build
PeterSurda commented 2021-01-12 16:08:12 +00:00
Owner
Copy Link

FROM pybm-build AS buildbot-test

`FROM pybm-build AS buildbot-test`
build.sh Outdated
@ -0,0 +1,17 @@
#!/bin/sh
PeterSurda commented 2021-01-12 16:14:02 +00:00
Owner
Copy Link

needs to be adjusted to use the new Dockerfile

needs to be adjusted to use the new `Dockerfile`
docker/bionic-buildenv.docker Outdated
@ -6,13 +6,15 @@ RUN dpkg --add-architecture i386
PeterSurda commented 2021-01-12 16:14:33 +00:00
Owner
Copy Link

file should be removed and if needed missing contents moved to Dockerfile

file should be removed and if needed missing contents moved to `Dockerfile`
docker/bionic-travis.docker Outdated
@ -1,10 +1,15 @@
FROM pybm-build
PeterSurda commented 2021-01-12 16:15:04 +00:00
Owner
Copy Link

file should be removed, missing contents moved to Dockerfile

file should be removed, missing contents moved to `Dockerfile`
PeterSurda commented 2021-01-12 16:16:11 +00:00
Owner
Copy Link

Also, you should squash the commits, PGP sign them and upload your PGP key to your account's settings.

Also, you should squash the commits, PGP sign them and upload your PGP key to your account's settings.
cis-muzahid added 1 commit 2021-01-14 06:59:02 +00:00
PeterSurda changed title from merge to Update dockerfiles for multi stage build 2021-01-14 09:37:49 +00:00
cis-muzahid force-pushed merge from 6d81c80b40 to 17989a1e63 2021-01-14 09:55:01 +00:00 Compare
PeterSurda approved these changes 2021-01-14 15:40:12 +00:00
PeterSurda merged commit 17989a1e63 into master 2021-01-14 15:40:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-build#1
No description provided.
Delete Branch "cis-muzahid/PyBitmessage-build:merge"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?