Bitmessage/bitmessage-js
2
0
Fork 1
Code Issues 1 Pull Requests 1 Actions Packages Releases Activity

Initial update for the bitmessage-js package #1

Merged
PeterSurda merged 15 commits from lee.miller/bitmessage-js:mac into master 2024-03-08 01:55:30 +01:00
Conversation 1 Commits 15 Files Changed 20 +294 -241
lee.miller commented 2023-01-08 20:54:05 +01:00
Contributor
Copy Link

Hello!

Here are the initial changes for the bitmessage-js package:

  • package update: scoped name, version bump, URL changes
  • changes in worker.cc according to node-gyp warnings
  • a buildbot dir in hope for future support for a node:16 container

TODO:

  • replace new Buffer() everywhere

  • make tests succeed

  • make research on workability of bn.js, maybe remove bignum?

Hello! Here are the initial changes for the `bitmessage-js` package: * package update: scoped name, version bump, URL changes * changes in `worker.cc` according to node-gyp warnings * a buildbot dir in hope for future support for a node:16 container TODO: - [x] replace `new Buffer()` everywhere - [x] make tests succeed - [ ] make research on workability of `bn.js`, maybe remove `bignum`?
lee.miller added 1 commit 2023-01-08 20:54:05 +01:00
lee.miller force-pushed mac from 8c5e47066e to 448755f53c 2024-02-27 23:34:43 +01:00 Compare
lee.miller force-pushed mac from ec57af94cd to a96d488cd4 2024-02-29 23:20:12 +01:00 Compare
lee.miller force-pushed mac from a96d488cd4 to 1d4b5141b9 2024-03-01 00:14:14 +01:00 Compare
lee.miller force-pushed mac from ebf1b0e853 to c9c4d0d8ee 2024-03-03 22:59:52 +01:00 Compare
lee.miller commented 2024-03-04 17:51:54 +01:00
Author
Contributor
Copy Link

I'm not sure if I need to replace new Buffer() also in lib/platform.browser.js or it's only the node deprecation.

I'm not sure if I need to replace `new Buffer()` also in `lib/platform.browser.js` or it's only the node deprecation.
lee.miller force-pushed mac from 317cf01c08 to 4730492ad5 2024-03-05 12:31:19 +01:00 Compare
lee.miller changed title from WIP: Initial update for the bitmessage-js package to Initial update for the bitmessage-js package 2024-03-05 13:00:16 +01:00
lee.miller requested review from PeterSurda 2024-03-05 17:21:24 +01:00
PeterSurda approved these changes 2024-03-07 14:38:44 +01:00
PeterSurda left a comment
Owner
Copy Link

Looks ok.

Looks ok.
lee.miller force-pushed mac from 4730492ad5 to 67712c69fa 2024-03-08 01:24:28 +01:00 Compare
PeterSurda merged commit 67712c69fa into master 2024-03-08 01:55:30 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/bitmessage-js#1
No description provided.
Delete Branch "lee.miller/bitmessage-js:mac"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?