Symlink support #14

Merged
PeterSurda merged 1 commits from PeterSurda/buildbot_multibuild:symlink into master 2022-04-12 08:33:19 +02:00
Owner
  • added some security checks so that symlinks can be supported
  • also some code quality changes
- added some security checks so that symlinks can be supported - also some code quality changes
PeterSurda added 1 commit 2022-04-12 08:33:04 +02:00
Symlink support
Some checks failed
buildbot/travis_bionic Build done.
buildbot/multibuild_parent Build done.
9d8b6f41b4
- added some security checks so that symlinks can be supported
- also some code quality changes
PeterSurda merged commit 9d8b6f41b4 into master 2022-04-12 08:33:19 +02:00
PeterSurda deleted branch symlink 2022-04-12 08:33:19 +02:00
lee.miller reviewed 2022-04-12 14:32:35 +02:00
@ -1,5 +1,5 @@
from os import listdir
from os.path import exists, isfile, join, islink
from os import getcwd, listdir
from os.path import exists, isfile, islink, join, realpath
Contributor

Wouldn't be better just import os here? See:

import os
help(os.path)
Wouldn't be better just `import os` here? See: ``` import os help(os.path) ```
lee.miller reviewed 2022-04-12 14:36:19 +02:00
@ -78,2 +85,3 @@
continue
if (exists(join(directory, item, 'Dockerfile')) and exists(join(directory, item, 'build.sh'))) or exists(join(directory, item, 'test.sh')):
if (exists(join(directory, item, 'Dockerfile'))
and exists(join(directory, item, 'build.sh'))) \
Contributor

backslash is not needed here

backslash is not needed here
Author
Owner

@lee.miller sure, you can make a PR, your suggestions look ok.

@lee.miller sure, you can make a PR, your suggestions look ok.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/buildbot_multibuild#14
No description provided.