Bitmessage/buildbot_multibuild
6
0
Fork 5
Code Issues 4 Pull Requests Projects Releases Wiki Activity

Symlink support #14

Merged
PeterSurda merged 1 commits from PeterSurda/buildbot_multibuild:symlink into master 2022-04-12 08:33:19 +02:00
Conversation 1 Commits 1 Files Changed 1 +22 -9
PeterSurda commented 2022-04-12 08:33:04 +02:00
Owner
Copy Link
  • added some security checks so that symlinks can be supported
  • also some code quality changes
- added some security checks so that symlinks can be supported - also some code quality changes
PeterSurda added 1 commit 2022-04-12 08:33:04 +02:00
Symlink support
Some checks failed
buildbot/travis_bionic Build done.
Details
buildbot/multibuild_parent Build done.
Details
9d8b6f41b4 
- added some security checks so that symlinks can be supported
- also some code quality changes
PeterSurda merged commit 9d8b6f41b4 into master 2022-04-12 08:33:19 +02:00
PeterSurda deleted branch symlink 2022-04-12 08:33:19 +02:00
lee.miller reviewed 2022-04-12 14:32:35 +02:00
lib/worker_multibuild.py
@ -1,5 +1,5 @@
from os import listdir
from os.path import exists, isfile, join, islink
from os import getcwd, listdir
from os.path import exists, isfile, islink, join, realpath
lee.miller commented 2022-04-12 14:32:35 +02:00
Contributor
Copy Link

Wouldn't be better just import os here? See:

import os
help(os.path)
Wouldn't be better just `import os` here? See: ``` import os help(os.path) ```
lee.miller reviewed 2022-04-12 14:36:19 +02:00
lib/worker_multibuild.py
@ -78,2 +85,3 @@
continue
if (exists(join(directory, item, 'Dockerfile')) and exists(join(directory, item, 'build.sh'))) or exists(join(directory, item, 'test.sh')):
if (exists(join(directory, item, 'Dockerfile'))
and exists(join(directory, item, 'build.sh'))) \
lee.miller commented 2022-04-12 14:36:19 +02:00
Contributor
Copy Link

backslash is not needed here

backslash is not needed here
PeterSurda commented 2022-04-14 07:26:24 +02:00
Author
Owner
Copy Link

@lee.miller sure, you can make a PR, your suggestions look ok.

@lee.miller sure, you can make a PR, your suggestions look ok.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/buildbot_multibuild#14
No description provided.
Delete Branch "PeterSurda/buildbot_multibuild:symlink"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?