Add xenial and jammy #15

Merged
PeterSurda merged 1 commits from shekhar-cis/buildbot_multibuild:refactor/buildbot_multibuild into master 2022-04-28 07:33:58 +00:00
Contributor

Hello,
I have added Docker for Jammy and Xenial.

Hello, I have added Docker for Jammy and Xenial.
shekhar-cis added 1 commit 2022-04-26 12:41:36 +00:00
shekhar-cis force-pushed refactor/buildbot_multibuild from 3b4db6c8b9 to 93886ed498 2022-04-26 13:28:46 +00:00 Compare
PeterSurda requested changes 2022-04-27 02:37:44 +00:00
PeterSurda left a comment
Owner

Looks like ok first attempt, please add a check at line 174 for KeyError in case we don't have the boostrapper for that particular distro.

Looks like ok first attempt, please add a check at line 174 for `KeyError` in case we don't have the boostrapper for that particular distro.
@ -54,0 +62,4 @@
git subversion python3-dev libffi-dev python3-setuptools \
python3-pip dumb-init curl openssh-client wget
RUN pip install --upgrade pip
Owner

Not sure why you install buildbot-worker with pip. Is there a problem installing it with apt?

Not sure why you install `buildbot-worker` with pip. Is there a problem installing it with apt?
Author
Contributor

I tried to install buildbot-worker with apt in docker build with "--pull --no-cache" but getting

E: Unable to locate package buildbot-worker
The command '/bin/sh -c apt-get install -yq --no-install-suggests --no-install-recommends      git subversion python3-dev libffi-dev python3-setuptools     python3-pip dumb-init curl openssh-client wget 
buildbot-worker' returned a non-zero code: 100

I found this python3-buildbot-worker is working with apt.

I tried to install `buildbot-worker` with apt in docker build with "--pull --no-cache" but getting ``` E: Unable to locate package buildbot-worker The command '/bin/sh -c apt-get install -yq --no-install-suggests --no-install-recommends git subversion python3-dev libffi-dev python3-setuptools python3-pip dumb-init curl openssh-client wget buildbot-worker' returned a non-zero code: 100 ``` I found this `python3-buildbot-worker` is working with apt.
Owner

maybe it is needed to run apt -y update after all. This is what a search shows up on focal:

root@focal:~# apt search buildbot-worker
Sorting... Done
Full Text Search... Done
buildbot-slave/focal 2.6.0-1 all
  transitional package for buildbot-worker

buildbot-worker/focal,now 2.6.0-1 all [installed]
  System to automate the compile/test cycle (worker agent)

python3-buildbot-worker/focal 2.6.0-1 all
  yet another transitional package for buildbot-worker
maybe it is needed to run `apt -y update` after all. This is what a search shows up on focal: ``` root@focal:~# apt search buildbot-worker Sorting... Done Full Text Search... Done buildbot-slave/focal 2.6.0-1 all transitional package for buildbot-worker buildbot-worker/focal,now 2.6.0-1 all [installed] System to automate the compile/test cycle (worker agent) python3-buildbot-worker/focal 2.6.0-1 all yet another transitional package for buildbot-worker ```
Author
Contributor

python3-buildbot-worker working.

`python3-buildbot-worker` working.
@ -115,6 +161,7 @@ def _get_dockerfile_contents(dockerfile):
if m:
inside_allowed_command = True
if m.group(1) == "FROM":
os_codename = m.group().split()[1].split(":")[1]
Owner

This looks like it may work it the typical use case.

This looks like it may work it the typical use case.
Author
Contributor

Added try except

Added `try except`
shekhar-cis force-pushed refactor/buildbot_multibuild from 93886ed498 to 1c26b97d27 2022-04-27 12:18:25 +00:00 Compare
shekhar-cis force-pushed refactor/buildbot_multibuild from 1c26b97d27 to 9f3da6d87d 2022-04-27 12:30:57 +00:00 Compare
shekhar-cis force-pushed refactor/buildbot_multibuild from 9f3da6d87d to cb7703c333 2022-04-27 12:31:55 +00:00 Compare
shekhar-cis force-pushed refactor/buildbot_multibuild from cb7703c333 to 1eefd5b0c6 2022-04-27 12:32:41 +00:00 Compare
shekhar-cis force-pushed refactor/buildbot_multibuild from 1eefd5b0c6 to ff87ae8ec5 2022-04-27 14:32:38 +00:00 Compare
PeterSurda approved these changes 2022-04-28 07:33:50 +00:00
PeterSurda merged commit ff87ae8ec5 into master 2022-04-28 07:33:58 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/buildbot_multibuild#15
No description provided.