Add xenial and jammy #15

shekhar-cis · 2022-04-26T12:41:35Z

shekhar-cis commented

2022-04-26 12:41:35 +00:00

Hello,
I have added Docker for Jammy and Xenial.

Hello, I have added Docker for Jammy and Xenial.

shekhar-cis force-pushed refactor/buildbot_multibuild from 3b4db6c8b9 to 93886ed498

2022-04-26 13:28:46 +00:00

Compare

PeterSurda requested changes 2022-04-27 02:37:44 +00:00

PeterSurda left a comment

Looks like ok first attempt, please add a check at line 174 for KeyError in case we don't have the boostrapper for that particular distro.

Looks like ok first attempt, please add a check at line 174 for `KeyError` in case we don't have the boostrapper for that particular distro.

lib/worker_multibuild.py Outdated

						
				@ -54,0 +62,4 @@

				    git subversion python3-dev libffi-dev python3-setuptools \

				    python3-pip dumb-init curl openssh-client wget

				RUN pip install --upgrade pip

PeterSurda commented

2022-04-27 02:35:32 +00:00

Not sure why you install buildbot-worker with pip. Is there a problem installing it with apt?

Not sure why you install `buildbot-worker` with pip. Is there a problem installing it with apt?

shekhar-cis commented

2022-04-27 10:46:58 +00:00

I tried to install buildbot-worker with apt in docker build with "--pull --no-cache" but getting

E: Unable to locate package buildbot-worker
The command '/bin/sh -c apt-get install -yq --no-install-suggests --no-install-recommends      git subversion python3-dev libffi-dev python3-setuptools     python3-pip dumb-init curl openssh-client wget 
buildbot-worker' returned a non-zero code: 100

I found this python3-buildbot-worker is working with apt.

I tried to install `buildbot-worker` with apt in docker build with "--pull --no-cache" but getting ``` E: Unable to locate package buildbot-worker The command '/bin/sh -c apt-get install -yq --no-install-suggests --no-install-recommends git subversion python3-dev libffi-dev python3-setuptools python3-pip dumb-init curl openssh-client wget buildbot-worker' returned a non-zero code: 100 ``` I found this `python3-buildbot-worker` is working with apt.

PeterSurda commented

2022-04-27 11:49:00 +00:00

maybe it is needed to run apt -y update after all. This is what a search shows up on focal:

root@focal:~# apt search buildbot-worker
Sorting... Done
Full Text Search... Done
buildbot-slave/focal 2.6.0-1 all
  transitional package for buildbot-worker

buildbot-worker/focal,now 2.6.0-1 all [installed]
  System to automate the compile/test cycle (worker agent)

python3-buildbot-worker/focal 2.6.0-1 all
  yet another transitional package for buildbot-worker

maybe it is needed to run `apt -y update` after all. This is what a search shows up on focal: ``` root@focal:~# apt search buildbot-worker Sorting... Done Full Text Search... Done buildbot-slave/focal 2.6.0-1 all transitional package for buildbot-worker buildbot-worker/focal,now 2.6.0-1 all [installed] System to automate the compile/test cycle (worker agent) python3-buildbot-worker/focal 2.6.0-1 all yet another transitional package for buildbot-worker ```

shekhar-cis commented

2022-04-27 12:41:13 +00:00

python3-buildbot-worker working.

`python3-buildbot-worker` working.

lib/worker_multibuild.py Outdated

						
				@ -115,6 +161,7 @@ def _get_dockerfile_contents(dockerfile):

				            if m:

				                inside_allowed_command = True

				                if m.group(1) == "FROM":

				                    os_codename = m.group().split()[1].split(":")[1]