Bitmessage/buildbot_multibuild
6
0
Fork 5
Code Issues 4 Pull Requests Projects Releases Wiki Activity

fixing configuration issues #5

Merged
PeterSurda merged 1 commits from cis-muzahid/buildbot_multibuild:kivy-test into master 2022-02-04 08:20:22 +01:00
Conversation 0 Commits 1 Files Changed 1 +12 -11
cis-muzahid commented 2022-02-03 17:25:19 +01:00
Member
Copy Link
No description provided.
cis-muzahid added 1 commit 2022-02-03 17:25:20 +01:00
fixing configuration issues
Some checks failed
buildbot/travis_bionic Build done.
Details
b0feb4ea90
PeterSurda reviewed 2022-02-04 08:18:56 +01:00
multibuild.py
@ -93,3 +94,3 @@
def get_dockerfile_contents(path, os_codename):
def get_dockerfile_contents(props):
PeterSurda commented 2022-02-04 08:18:56 +01:00
Owner
Copy Link

should be decorated renderer

should be decorated renderer
PeterSurda commented 2022-02-04 08:19:35 +01:00
Owner
Copy Link

at least I think, not 100% sure, since we're not calling it directly, it may not be necessary

at least I think, not 100% sure, since we're not calling it directly, it may not be necessary
PeterSurda marked this conversation as resolved
PeterSurda approved these changes 2022-02-04 08:20:10 +01:00
PeterSurda left a comment
Owner
Copy Link

apart from the decorator, which I'm not fully sure, looks ok.

apart from the decorator, which I'm not fully sure, looks ok.
PeterSurda merged commit b0feb4ea90 into master 2022-02-04 08:20:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/buildbot_multibuild#5
No description provided.
Delete Branch "cis-muzahid/buildbot_multibuild:kivy-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?