Peter Šurda PeterSurda
  • Joined on 2020-04-27
PeterSurda approved Sysdeploy/idlers-agent#20 2024-07-01 14:39:40 +00:00
Added nvme details
PeterSurda commented on issue Sysdeploy/idlers-agent#21 2024-07-01 07:44:56 +00:00
Use correct os id

At the moment, please add new issues via taiga, not gitea, they aren't synced, and we can't properly schedule work without the task being in taiga.

PeterSurda commented on pull request Sysdeploy/idlers-agent#20 2024-07-01 07:43:43 +00:00
Added nvme details

also, needs rebasing

PeterSurda commented on pull request Sysdeploy/idlers-agent#20 2024-07-01 07:43:31 +00:00
Added nvme details

I think this will include the character device, block device, and partitions (and also /dev/nvme-fabrics which I don't even know what it is). A better option is to look in /sys/block/nvme*. That will only include the main block device (e.g. nvme0n1), and then you can join /dev/ and the file name.

PeterSurda suggested changes for Sysdeploy/idlers-agent#20 2024-07-01 07:43:31 +00:00
Added nvme details
PeterSurda merged pull request Sysdeploy/idlers-agent#19 2024-06-28 15:28:08 +00:00
updated get_ram_and_disk method
PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-28 15:28:08 +00:00
ea4675a56c updated get_ram_and_disk method
PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-27 14:58:57 +00:00
bd6ecc3519 Added SATA details in note
PeterSurda merged pull request Sysdeploy/idlers-agent#18 2024-06-27 14:58:55 +00:00
Added SATA details in note
PeterSurda commented on pull request Sysdeploy/idlers-agent#18 2024-06-27 14:58:50 +00:00
Added SATA details in note

There's no lsblk in Synology DSM or openwrt. You could search for /sys/block/*/device similarly as when looking for the disk sizes.

PeterSurda approved Sysdeploy/idlers-agent#18 2024-06-27 14:58:50 +00:00
Added SATA details in note

You can remove dependency on lsblk in the next PR.

PeterSurda merged pull request Sysdeploy/idlers-agent#15 2024-06-27 08:48:12 +00:00
disk space calculation using /sys/block/
PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-27 08:48:12 +00:00
54d0b0decd disk space calculation using /sys/block/
PeterSurda commented on pull request Sysdeploy/idlers-agent#15 2024-06-27 08:47:23 +00:00
disk space calculation using /sys/block/

This can be rounded up, because on systems which have 1GB of RAM, it will result in 0GB (because it subtracts the amount allocated for the kernel).

PeterSurda commented on pull request Sysdeploy/idlers-agent#15 2024-06-27 08:47:23 +00:00
disk space calculation using /sys/block/

There is a trick to make the code more readable. Use a negative condition and continue. This will reduce indentation.

PeterSurda approved Sysdeploy/idlers-agent#15 2024-06-27 08:47:23 +00:00
disk space calculation using /sys/block/

I'm merging, please address my comments in the next PR.

PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-26 22:57:59 +00:00
8f79919659 Updated ecc logic, added RAM configured speed
PeterSurda merged pull request Sysdeploy/idlers-agent#17 2024-06-26 22:57:58 +00:00
Updated ecc logic, added RAM configured speed