Added nvme details #20

Merged
PeterSurda merged 2 commits from swapnil/idlers-agent:main into main 2024-07-01 16:39:46 +02:00
Member
No description provided.
PeterSurda requested changes 2024-07-01 09:43:30 +02:00
Dismissed
agent.py Outdated
@ -138,0 +157,4 @@
return devices
# Get the list of nvme devices starting with 'nvme'
nvme_devices = [device for device in os.listdir('/dev') if device.startswith('nvme')]
Owner

I think this will include the character device, block device, and partitions (and also /dev/nvme-fabrics which I don't even know what it is). A better option is to look in /sys/block/nvme*. That will only include the main block device (e.g. nvme0n1), and then you can join /dev/ and the file name.

I think this will include the character device, block device, and partitions (and also `/dev/nvme-fabrics` which I don't even know what it is). A better option is to look in `/sys/block/nvme*`. That will only include the main block device (e.g. `nvme0n1`), and then you can join `/dev/` and the file name.
PeterSurda marked this conversation as resolved
Owner

also, needs rebasing

also, needs rebasing
swapnil force-pushed main from 6a3c5737e5 to 75744e0010 2024-07-01 14:46:01 +02:00 Compare
PeterSurda approved these changes 2024-07-01 16:39:40 +02:00
PeterSurda merged commit 75744e0010 into main 2024-07-01 16:39:46 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sysdeploy/idlers-agent#20
No description provided.