Sysdeploy/ansible-modules-syncthing
5
0
Fork 2
Code Issues 4 Pull Requests 4 Packages Projects 2 Releases Wiki Activity

created common.py for extracting deep comparision function. #11

Merged
PeterSurda merged 1 commits from shailaja/ansible-modules-syncthing:common_file into master 2024-06-10 13:38:52 +00:00
Conversation 0 Commits 1 Files Changed 2 +37 -3
shailaja commented 2024-06-04 00:18:25 +00:00
Member
Copy Link

closes #10

closes #10
shailaja requested review from PeterSurda 2024-06-04 00:18:48 +00:00
shailaja requested review from swapnil 2024-06-04 00:18:48 +00:00
PeterSurda requested changes 2024-06-04 00:36:10 +00:00
Dismissed
collection/plugins/modules/device_defaults.py Outdated
@ -151,11 +151,9 @@ response:
'''
from ansible_collections.community.syncthing.plugins.module_utils.syncthing_api import SyncthingModule
from common.py import deep_equal
PeterSurda commented 2024-06-04 00:36:03 +00:00
Owner
Copy Link

due to how ansible loads modules, this needs to have a different format, I think the correct one is:

from ansible_collections.community.syncthing.plugins.module_utils.common import deep_equal

due to how ansible loads modules, this needs to have a different format, I think the correct one is: `from ansible_collections.community.syncthing.plugins.module_utils.common import deep_equal`
PeterSurda marked this conversation as resolved
shailaja force-pushed common_file from 7f340539db to 00cfcd42a6 2024-06-06 04:30:52 +00:00 Compare
shailaja requested review from PeterSurda 2024-06-06 04:32:09 +00:00
PeterSurda requested changes 2024-06-06 04:56:29 +00:00
Dismissed
collection/plugins/modules/device_defaults.py Outdated
@ -151,11 +151,9 @@ response:
'''
from ansible_collections.community.syncthing.plugins.module_utils.syncthing_api import SyncthingModule
from common.py import deep_equalfrom ansible_collections.community.syncthing.plugins.module_utils.common import get_changes
PeterSurda commented 2024-06-06 04:55:05 +00:00
Owner
Copy Link

This doesn't look syntactically correct

This doesn't look syntactically correct
shailaja force-pushed common_file from b55ace242a to 4b476a8c3d 2024-06-06 05:07:53 +00:00 Compare
PeterSurda approved these changes 2024-06-10 13:38:44 +00:00
PeterSurda merged commit 4b476a8c3d into master 2024-06-10 13:38:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
swapnil
PeterSurda
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sysdeploy/ansible-modules-syncthing#11
No description provided.
Delete Branch "shailaja/ansible-modules-syncthing:common_file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?