Added device_default #2

swapnil · 2024-04-30T12:05:39+02:00

swapnil commented

2024-04-30 12:05:39 +02:00

No description provided.

swapnil force-pushed master from 46448fab1d to 8d6e24c460

2024-05-02 09:13:28 +02:00

Compare

swapnil force-pushed master from 78def8612f to 71f3168dfd

2024-05-02 10:21:32 +02:00

Compare

PeterSurda requested changes 2024-05-03 05:56:44 +02:00

Dismissed

collection/plugins/modules/device_default.py Outdated

						
				@ -0,0 +182,4 @@

				    current_config = module.get_call()

				    # Check for changes

				    changes = {key: module.params[key] for key in module.params if module.params.get(key) != current_config.get(key)}

PeterSurda commented

2024-05-03 05:45:24 +02:00

does this work correctly on lists? e.g. allowedNetworks, igoredFolders?

does this work correctly on lists? e.g. `allowedNetworks`, `igoredFolders`?

collection/plugins/modules/device_default.py Outdated

						
				@ -0,0 +184,4 @@

				    # Check for changes

				    changes = {key: module.params[key] for key in module.params if module.params.get(key) != current_config.get(key)}

				    if len(changes.keys()) > 0:

PeterSurda commented

2024-05-03 05:56:27 +02:00

how about

if module.check_mode or changes.keys() == 0:
   module.result['device_default'] = current_config
   module_exit_json()

module.patch_call(data=module.params)
module.result['device_default'] = module.get_call()
module.result['changed'] = True
module.result['changes'] = changes

how about ``` if module.check_mode or changes.keys() == 0: module.result['device_default'] = current_config module_exit_json() module.patch_call(data=module.params) module.result['device_default'] = module.get_call() module.result['changed'] = True module.result['changes'] = changes ```