Sysdeploy
/
collectd-btrfs
2
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added interval in btrfs #2

Merged
PeterSurda merged 1 commits from shailaja/collectd-btrfs:new_metric into main 2023-11-16 11:35:34 +00:00
Conversation 1 Commits 1 Files Changed 1 +5 -3
shailaja commented 2023-11-08 06:49:54 +00:00
Member
Copy Link
No description provided.
shailaja added 1 commit 2023-11-08 06:49:54 +00:00
shailaja requested review from PeterSurda 2023-11-08 06:50:03 +00:00
PeterSurda requested changes 2023-11-08 07:04:53 +00:00
PeterSurda left a comment
Owner
Copy Link

I think this isn't sufficient. You also need to update the callback frequency. Documentation (register_read):

https://collectd.org/documentation/manpages/collectd-python.5.shtml#functions

Example:

bc06a7344d

I think this isn't sufficient. You also need to update the callback frequency. Documentation (`register_read`): https://collectd.org/documentation/manpages/collectd-python.5.shtml#functions Example: https://github.com/traylenator/collectd-facter/commit/bc06a7344d33703df4d5cda1bc5957a1b246867a
PeterSurda commented 2023-11-08 07:05:42 +00:00
Owner
Copy Link

Also, we're trying to avoid magic values, so we should define the 600 as a constant.

Also, we're trying to avoid magic values, so we should define the 600 as a constant.
shailaja added 1 commit 2023-11-08 17:31:47 +00:00
shailaja force-pushed new_metric from c684beab6f to 4dae2cd4dc 2023-11-08 17:37:36 +00:00 Compare
PeterSurda approved these changes 2023-11-16 11:34:36 +00:00
PeterSurda left a comment
Owner
Copy Link

Looks ok.

Looks ok.
PeterSurda merged commit 4dae2cd4dc into main 2023-11-16 11:35:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sysdeploy/collectd-btrfs#2
No description provided.
Delete Branch "shailaja/collectd-btrfs:new_metric"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?