Sysdeploy
/
influx-smtp-gateway
2
0
Fork 1
Code Issues Pull Requests 2 Projects Releases Wiki Activity

smtp-handling #3

Open
PeterSurda wants to merge 3 commits from cis-kuldeep/influx-smtp-gateway:smtp-handling into master
pull from: cis-kuldeep/influx-smtp-gateway:smtp-handling
merge into: Sysdeploy:master
Conversation 0 Commits 3 Files Changed 1 +57 -25
PeterSurda commented 2022-02-25 06:49:01 +00:00
Owner
Copy Link
No description provided.
PeterSurda added 2 commits 2022-02-25 06:49:01 +00:00
PeterSurda reviewed 2022-02-25 06:53:26 +00:00
PeterSurda left a comment
Author
Owner
Copy Link

replace prints with debug log

replace prints with debug log
main.py
@ -23,3 +30,4 @@
SMTP webhook server
"""
def create_new_client(self, response):
PeterSurda commented 2022-02-25 06:51:10 +00:00
Author
Owner
Copy Link

needs to return a value (e.g. boolean)

needs to return a value (e.g. boolean)
main.py
@ -26,0 +42,4 @@
"message": "some error: {}".format(e)}
print("response1: ", response)
def smtp_login(self, response, msg):
PeterSurda commented 2022-02-25 06:51:23 +00:00
Author
Owner
Copy Link

needs to return a value

needs to return a value
main.py
@ -79,0 +94,4 @@
if (c == 1):
soft_return("can't connect")
self.create_new_client(response)
PeterSurda commented 2022-02-25 06:53:03 +00:00
Author
Owner
Copy Link

need to check for return value and skip login if connect fails

need to check for return value and skip `login` if `connect` fails
cis-kuldeep added 1 commit 2022-02-25 13:55:42 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b cis-kuldeep-smtp-handling master
git pull smtp-handling

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff cis-kuldeep-smtp-handling
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sysdeploy/influx-smtp-gateway#3
No description provided.
Delete Branch "cis-kuldeep/influx-smtp-gateway:smtp-handling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?