Sysdeploy/ipxe_scripts
2
0
Fork 1
Code Issues 3 Pull Requests Projects Releases 74 Wiki Activity

Do not clone IPXE since it's a submodule #3

Manually merged
maxweiss merged 1 commits from maxweiss/ipxe_scripts:dont_clone_ipxe into master 2021-04-29 21:55:55 +02:00
Conversation 1 Commits 1 Files Changed 1 +5 -5
maxweiss commented 2021-04-29 08:09:08 +02:00
Contributor
Copy Link

This is a quick-fix to not break the current BuildBot steps while working with the fact that IPXE is a submodule in the repo. Now, when BuildBot calls the "clone_ipxe_upstream" function, which used to clone and checkout the repo, it instead simply cd's to the submodule and checks out the desired commit. Eventually, the BuildBot step may be changed, but in the meantime, this should be a non-disruptive workaround.

This is a quick-fix to not break the current BuildBot steps while working with the fact that IPXE is a submodule in the repo. Now, when BuildBot calls the "clone_ipxe_upstream" function, which used to clone and checkout the repo, it instead simply cd's to the submodule and checks out the desired commit. Eventually, the BuildBot step may be changed, but in the meantime, this should be a non-disruptive workaround.
maxweiss requested review from PeterSurda 2021-04-29 08:09:18 +02:00
PeterSurda approved these changes 2021-04-29 21:47:19 +02:00
maxweiss force-pushed dont_clone_ipxe from f95446ad9f to 9a524663cc 2021-04-29 21:55:09 +02:00 Compare
maxweiss manually merged commit d92de073f4 into master 2021-04-29 21:55:55 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
PeterSurda
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Buildbot PeterSurda
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sysdeploy/ipxe_scripts#3
No description provided.
Delete Branch "maxweiss/ipxe_scripts:dont_clone_ipxe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?