Sysdeploy/openwrt
2
0
Fork 2
Code Issues 5 Pull Requests 2 Packages Projects 1 Releases Wiki Activity

Make a package for nvme-cli and include it into the images. #48

Merged
PeterSurda merged 1 commits from lee.miller/openwrt:nvme into main 2023-06-20 05:12:17 +02:00
Conversation 4 Commits 1 Files Changed 2 +57 -3
lee.miller commented 2023-06-17 03:12:11 +02:00
Collaborator
Copy Link

Hi!

Addressing the #47. The nvme-cli is actually a mega-package which includes also libnvme and json-c. The dependencies can be separated into additional packages if there will be other depending packages in the future.

Hi! Addressing the #47. The `nvme-cli` is actually a mega-package which includes also `libnvme` and `json-c`. The dependencies can be separated into additional packages if there will be other depending packages in the future.
PeterSurda commented 2023-06-18 08:23:16 +02:00
Owner
Copy Link

I'll check it tomorrow, in the meantime can you move the installation to the waveshare image? I don't need it in the other two.

I'll check it tomorrow, in the meantime can you move the installation to the `waveshare` image? I don't need it in the other two.
lee.miller force-pushed nvme from e75e49e588 to 5aa3141ed8 2023-06-18 18:03:46 +02:00 Compare
lee.miller commented 2023-06-18 18:05:12 +02:00
Author
Collaborator
Copy Link

I'll check it tomorrow, in the meantime can you move the installation to the waveshare image? I don't need it in the other two.

Done. Should I move also kmod-nvme?

> I'll check it tomorrow, in the meantime can you move the installation to the `waveshare` image? I don't need it in the other two. Done. Should I move also `kmod-nvme`?
lee.miller force-pushed nvme from 5aa3141ed8 to def7d4097f 2023-06-18 22:16:44 +02:00 Compare
PeterSurda commented 2023-06-19 03:56:14 +02:00
Owner
Copy Link

I'll check it tomorrow, in the meantime can you move the installation to the waveshare image? I don't need it in the other two.

Done. Should I move also kmod-nvme?

Yes that's a great idea please do that.

> > I'll check it tomorrow, in the meantime can you move the installation to the `waveshare` image? I don't need it in the other two. > > Done. Should I move also `kmod-nvme`? Yes that's a great idea please do that.
PeterSurda approved these changes 2023-06-19 06:52:34 +02:00
PeterSurda left a comment
Owner
Copy Link

It works, except the name of the executable but that's not a big deal.

It works, except the name of the executable but that's not a big deal.
feed/nvme-cli/Makefile Outdated
@ -0,0 +34,4 @@
define Package/$(PKG_NAME)/install
$(INSTALL_DIR) $(1)/usr/sbin
$(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/sbin/nvme $(1)/usr/sbin/nvme-cli
PeterSurda commented 2023-06-19 06:52:17 +02:00
Owner
Copy Link

It shouldn't be nvme-cli, it isn't called nvme-cli in Ubuntu for example. Just nvme.

It shouldn't be `nvme-cli`, it isn't called `nvme-cli` in Ubuntu for example. Just `nvme`.
lee.miller marked this conversation as resolved
lee.miller force-pushed nvme from def7d4097f to aed9b64b71 2023-06-19 13:50:40 +02:00 Compare
PeterSurda commented 2023-06-20 05:12:07 +02:00
Owner
Copy Link

All good.

All good.
PeterSurda merged commit aed9b64b71 into main 2023-06-20 05:12:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sysdeploy/openwrt#48
No description provided.
Delete Branch "lee.miller/openwrt:nvme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?