Commit Graph

2662 Commits

Author SHA1 Message Date
Peter Šurda 0c9cb4824d
Memory leak (kind of) fix
- objectsKnownToThem is supposed to track if it's necessary to send inv
  commands to a peer
- it is supposed to enter garbage collection after 1 hour
  (ObjectTracker.trackingExpires)
- due to peer not announcing all objects, or announcing them before we
  announce, this contains excessive number of entries after connection
  is fully established.
- profiling revealed that this creates unnecessary memory to be kept
  allocated
- this patch will prevent tracking of entries sent during bigInv,
  reducing the memory "leak"
- it is possible, in theory, that this does have some negative effect,
  like increased bandwidth or neglecting to announce some invs. It
  probably doesn't though as my review of objectsKnownToThem occurrences
  didn't reveal any such case, and since the dict didn't track fully
  accurately anyway (so it would have already been broken if it was a
  problem), I consider it an acceptable risk at the moment. If it indeed
  causes problems, they can be solved separately
- I tested this on one of the bootstrap servers with little memory, and
  it increased the number of connections than can be handled by a factor
  of about 3.5
2018-04-01 11:39:02 +02:00
Peter Šurda 50ccb897fc
Merge branch '1148' into upstream-v0.6 2018-03-29 07:34:48 +02:00
Peter Šurda d5ae5cd1a5
Merge branch '1188' into upstream-v0.6 2018-03-28 07:44:24 +02:00
Dmitri Bogomolov 2268413cd0
Do not try to connect namecoin if dontconnect set in config (#1146) 2018-03-26 16:47:22 +03:00
Peter Šurda 73ebad4a4e
Merge branch '1179' into upstream-v0.6 2018-03-24 09:43:11 +01:00
Peter Šurda 6430ea7fe6
Merge branch '1171' into upstream-v0.6 2018-03-24 09:40:35 +01:00
sigoa 4f0317575f
shorten sentence , offer beamstat link
the link to beamstat will be very good for people who don't know what all the mumbo-jumbo is about
2018-03-23 04:51:50 +01:00
Dmitri Bogomolov cec8519e43
Added "apiinterface" and "apiport" to BMConfigDefaults 2018-03-22 17:50:26 +02:00
Peter Šurda 55d6239e3d
Merge branch '952' into upstream-v0.6 2018-03-22 16:16:24 +01:00
Dmitri Bogomolov d974065f8e
Handle exceptions from python without ipv6 support 2018-03-22 17:13:34 +02:00
Peter Šurda d7ac440a04
Merge branch '1172' into upstream-v0.6 2018-03-22 16:12:53 +01:00
Dmitri Bogomolov 9ccd3a0989
Prevent settingsDialog from setting dontconnect = false
if "Work offline" was checked in the ConnectDialog
2018-03-22 17:10:29 +02:00
Dmitri Bogomolov 6cefaf87e9
Module foldertree: changed subclassing order to reuse common code 2018-03-22 14:55:30 +02:00
Dmitri Bogomolov 90eca36b5d
Module foldertree: simplified a bit and did flake8 2018-03-22 14:55:25 +02:00
Dmitri Bogomolov 6562502416
Even more unused variables 2018-03-22 13:48:07 +02:00
Dmitri Bogomolov e43bd36618
More unused variables 2018-03-22 13:23:36 +02:00
Dmitri Bogomolov d91c3a6b0c
Removed unnecessary comment and percent formatting in logger.error 2018-03-22 12:13:47 +02:00
Dmitri Bogomolov d447db907c
Address operations: simplified the code a bit 2018-03-22 12:13:47 +02:00
Dmitri Bogomolov 006b98389b
Address operations: flake8 2018-03-22 12:13:47 +02:00
Peter Šurda cbb228db8b
Merge branch '1180' into upstream-v0.6 2018-03-22 11:08:51 +01:00
Mahendra 8d48164734
fix indentation error in dependency file 2018-03-22 15:27:37 +05:30
Peter Šurda 5721ca53fd
Merge branch '1174' into upstream-v0.6 2018-03-22 08:31:25 +01:00
Mahendra 1a36361ef9
replace all random.xxx with helper random function 2018-03-21 19:26:27 +05:30
Peter Šurda d7cd294eb4
Merge branch '1173' into upstream-v0.6 2018-03-21 14:14:08 +01:00
Mahendra 6076e1832a
implement more helper random changes with replace random.xxx 2018-03-21 18:19:08 +05:30
Peter Šurda f3960c1638
Merge branch '1170' into upstream-v0.6 2018-03-21 13:08:10 +01:00
Mahendra 1ad321b08a
replace random.xxx with calls to the helper_random function 2018-03-21 17:22:23 +05:30
Peter Šurda 08888117af
Merge branch '1169' into upstream-v0.6 2018-03-21 11:57:15 +01:00
Mahendra 48b8af975a
added random(sample, shuffle, randrange) methods in helper_random 2018-03-21 16:13:43 +05:30
Mahendra ee7b591c6c
added docstring for requirement dependency 2018-03-21 15:47:55 +05:30
Peter Šurda ef1cd5a9bd
Merge branch '1159' into upstream-v0.6 2018-03-20 06:49:42 +01:00
sigoa 84c94ad748
codacy no like ` this ` 2018-03-18 11:50:57 +01:00
sigoa c93b31dd45
backticks problematic 2018-03-18 11:46:10 +01:00
Peter Šurda 20b5c3552f
Merge branch '1145' into upstream-v0.6 2018-03-16 15:03:30 +01:00
Peter Šurda 39e46c7078
Merge branch '1151' into upstream-v0.6 2018-03-16 13:34:09 +01:00
Dmitri Bogomolov 72299483c4
Do not duplicate avatar in address column of Address book 2018-03-14 16:34:03 +02:00
Humz 301cd9639c
Update LICENSE
changed license to match feedback
2018-03-14 14:05:56 +00:00
Peter Šurda 1e037024c3
Merge branch '1156' into upstream-v0.6 2018-03-14 13:59:40 +01:00
Peter Šurda 9bd60c4a0f
Merge branch '1153' into upstream-v0.6 2018-03-14 13:59:21 +01:00
Dmitri Bogomolov 50b74c2223
No lib symlinks in openwrt 2018-03-14 12:56:23 +02:00
Dmitri Bogomolov 0ef0e6b020
Added docstrings. Removed unused method Image.save(). 2018-03-14 08:57:51 +02:00
Dmitri Bogomolov 0ddc56e83a
Added schema 'bitmessage:', it's unreadable otherwise for some reason 2018-03-14 08:57:20 +02:00
PyBitmessage Translations f9c66956c5
Auto-updated language ja from transifex 2018-03-13 16:15:59 +01:00
Dmitri Bogomolov 3850a920c9
Do not add gui.menu plugins with prefix 'address' to "All accounts" item 2018-03-13 13:46:47 +02:00
Dmitri Bogomolov 08a2115412
Properly renamed qrcode plugin module and made menu available
for all address entries except for addressbook and blacklist
2018-03-13 13:46:47 +02:00
Dmitri Bogomolov 77e779638c
Removed unnecessary code in qrcode plugin 2018-03-13 13:46:47 +02:00
Peter Šurda 4b995e7996
Fix circular import
- previous commit broke
2018-03-13 11:42:43 +01:00
Peter Šurda af2bb95601
Remove unused imports 2018-03-13 07:41:59 +01:00
Peter Šurda 1e4400a207
Remove obsolete code
- PendingDownload and PendingUpload in inventory.py are obsolete
- the replacement functions only provide lengths and are in
  network/stats.py
2018-03-13 07:32:23 +01:00
Peter Šurda 7938eab454
Remove obsolete files 2018-03-11 20:38:58 +01:00