swapnil
0 Followers · 0 Following
  • India
  • Joined on 2022-03-05
Repositories
7
 Projects Packages Public Activity Starred Repositories
swapnil created pull request swapnil/idlers-agent#2 2024-07-04 09:52:55 +02:00
Test Pull - 2 - Auto rebase
swapnil created pull request swapnil/idlers-agent#1 2024-07-04 09:52:32 +02:00
Test Pull - 1
swapnil pushed to test/pull-3 at swapnil/idlers-agent 2024-07-04 09:50:25 +02:00
swapnil created branch test/pull-3 in swapnil/idlers-agent 2024-07-04 09:50:25 +02:00
swapnil pushed to test/pull-2 at swapnil/idlers-agent 2024-07-04 09:50:14 +02:00
swapnil created branch test/pull-2 in swapnil/idlers-agent 2024-07-04 09:50:14 +02:00
swapnil pushed to test/pull-1 at swapnil/idlers-agent 2024-07-04 09:50:05 +02:00
swapnil created branch test/pull-1 in swapnil/idlers-agent 2024-07-04 09:50:05 +02:00
swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 15:46:08 +02:00
getting os details with /api/os

Don't need to do if-else. can be one-liner like other get_* methods.

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 15:44:36 +02:00
getting os details with /api/os

Missing parameter for os list.

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 15:43:54 +02:00
getting os details with /api/os

It's still not using id and versionId

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 15:43:15 +02:00
getting os details with /api/os

os id cannot be none, so at least this method should never return a None. Also, this case should never practically happen, even if it happens, you can return 1.

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 15:25:17 +02:00
getting os details with /api/os

Why is almost entry method is wrapped up in try-except? Please list down the cases where you think it'll break inside the try and this try-except will be useful.

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 08:09:59 +02:00
getting os details with /api/os

I think you mean get_os_id

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 08:09:07 +02:00
getting os details with /api/os

Missing parameter for os list

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 08:05:29 +02:00
getting os details with /api/os

Again, we should use send_request here

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 08:03:21 +02:00
getting os details with /api/os

Instead of returning a hard-coded nnumber, we'll return "other" or "custom" id

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 08:02:27 +02:00
getting os details with /api/os

Since /etc/os-release doesn't exist on openwrt, we should fallback to /etc/VERSION.

swapnil commented on pull request Sysdeploy/idlers-agent#22 2024-07-03 07:58:05 +02:00
getting os details with /api/os

As discussed, we should use a combination of id and versionId. Check the exact key name in the file.

swapnil commented on issue Sysdeploy/idlers-agent#5 2024-07-02 06:11:12 +02:00
Hardware info in notes

@PeterSurda can we close this now?