• India
  • Joined on 2022-03-05
swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-20 10:36:32 +00:00
url encoding with python

@PeterSurda this LGTM 👍

swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-17 14:42:16 +00:00
url encoding with python

@shailaja I tested the latest code in shailja_test branch on test2 server and found that it's working fine, meaning url is generated properly. Please update this PR to include latest changes.

swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-14 13:49:55 +00:00
url encoding with python

@shailaja I looked at the image and the latest code on the test server. The code on the test server does not match with the one in the PR. Could you test once on the updated code? Let me know if…

swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-14 13:31:24 +00:00
url encoding with python

@shailaja changes looks fine now. Have you tested the app code with the latest changes?

yes ,but facing the same issue which is because of email

That's not a problem. That's…

swapnil suggested changes for PeterSurda/inoreader2readwise#4 2024-02-14 12:17:43 +00:00
url encoding with python
swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-14 12:17:43 +00:00
url encoding with python

Format this part. Does not look very nice. Maybe pass each parameter on a different line.

swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-14 12:14:50 +00:00
url encoding with python

@shailaja changes looks fine now. Have you tested the app code with the latest changes?

swapnil commented on pull request PeterSurda/inoreader2readwise#4 2024-02-14 05:44:22 +00:00
url encoding with python

@shailaja Please include only the required changes.

Upon comparision I found that

  • Entire 'home' function has been changed, which is not reuired. Ideally, you'd only add the section to create…
swapnil commented on pull request PeterSurda/inoreader2readwise#3 2024-02-11 14:55:01 +00:00
Services/part2

Just saw that new html templates have been added in the outer 'templates' folder instead of 'app/templates' folder where it's actually being referenced from. I think we should also remove outer…

swapnil commented on pull request PeterSurda/inoreader2readwise#2 2024-02-09 08:53:48 +00:00
all template files(home,login)

A simple href with already constructed url looks a good suggestion to me.

swapnil commented on pull request PeterSurda/inoreader2readwise#2 2024-02-09 08:41:35 +00:00
all template files(home,login)

@shailaja You forgot to remove the script part in the template. JS script is no more required as we'll send the created oauth_url from python code.

swapnil commented on pull request PeterSurda/inoreader2readwise#2 2024-02-08 13:03:05 +00:00
all template files(home,login)

Why is JS a problem?

swapnil commented on pull request PeterSurda/inoreader2readwise#2 2024-02-08 10:31:47 +00:00
all template files(home,login)

@PeterSurda this is what you wanted?

swapnil commented on pull request PeterSurda/inoreader2readwise#1 2024-02-07 08:14:58 +00:00
Separate services - app, db, and job

@shailaja As suggested by Peter, we need to split this PR into 5 relatively small PRs. Splitting will be as we have discussed in the call. Pasting here the parts for your reference:

split it…

swapnil pushed to main at swapnil/inoreader2readwise 2024-02-07 07:13:38 +00:00
a43479276b fixes: constant AUTH_URL & better csrf handeling
swapnil created pull request PeterSurda/inoreader2readwise#1 2024-02-01 11:09:50 +00:00
Separate services - app, db, and job
swapnil pushed to main at swapnil/inoreader2readwise 2024-02-01 11:08:33 +00:00
10dab44a27 app: update dummy.env
68869249bc app: fix user_info error
dd850ca6e1 app: minor improvements
706ff9d90f db: Table and apis for last annotation time
889469dcff job: get/update last annotation time from database
Compare 36 commits »
swapnil pushed to main at swapnil/inoreader2readwise 2024-02-01 11:06:12 +00:00
87fcc243e6 app: update dummy.env
swapnil pushed to main at swapnil/inoreader2readwise 2024-02-01 10:59:53 +00:00
ff8a34afd5 app: fix user_info error
swapnil pushed to main at swapnil/inoreader2readwise 2024-02-01 10:55:17 +00:00
ab44ad09f6 app: minor improvements
86c51478da db: Table and apis for last annotation time
73260297ef job: get/update last annotation time from database
Compare 3 commits »