Bitmessage/PyBitmessage-2025-02-20
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 54 Actions Packages Projects Releases 5 Wiki Activity

More fixes for l10n #981

Closed
g1itch wants to merge 5 commits from l10n into v0.6
pull from: l10n
merge into: Bitmessage:v0.6
Conversation 6 Commits 5 Files Changed 9 +249 -119
g1itch commented 2017-03-16 16:55:47 +01:00 (Migrated from github.com)
Copy Link

When I was looking for the reason why pylupdate4 not includes the string "Show QR-code" into ts-files, I noticed that almost any widget module defines the _translate() function and calls it with many default values for the positional arguments. Fix me, I think _translate should be imported from tr where it's already defined for all cases and with the proper defaults. Here I edited only the modules __init__ and networkstatus because it will not probably be generated from ui-files.

The disadvantage of this changeset is that pylupdate4 will mark all strings in that changed _translate() calls as "obsolete" and translators on transifex will be forced to copy suggestion into translation for each of it.

When I was looking for the reason why pylupdate4 not includes the string "Show QR-code" into ts-files, I noticed that almost any widget module defines the `_translate()` function and calls it with many default values for the positional arguments. Fix me, I think `_translate` should be imported from `tr` where it's already defined for all cases and with the proper defaults. Here I edited only the modules `__init__` and `networkstatus` because it will not probably be generated from ui-files. The disadvantage of this changeset is that pylupdate4 will mark all strings in that changed `_translate()` calls as "obsolete" and translators on transifex will be forced to copy suggestion into translation for each of it.
g1itch commented 2017-03-16 19:20:11 +01:00 (Migrated from github.com)
Copy Link

Hmm, this not works at all with keyword args. New strings should be marked "unfinished", not "obsolete". Investigating...

Hmm, this not works at all with keyword args. New strings should be marked "unfinished", not "obsolete". Investigating...
PeterSurda commented 2017-03-17 14:57:20 +01:00 (Migrated from github.com)
Copy Link

Thanks for doing this, let me know when you're done so that I can review it.

Thanks for doing this, let me know when you're done so that I can review it.
g1itch commented 2017-03-17 15:06:04 +01:00 (Migrated from github.com)
Copy Link

I think it's finished already (for this two modules). Not squashing yet to be able to drop undesirable commits if any (what about 'synchronisation' for example?).

I think it's finished already (for this two modules). Not squashing yet to be able to drop undesirable commits if any (what about 'synchronisation' for example?).
g1itch commented 2017-03-24 00:01:06 +01:00 (Migrated from github.com)
Copy Link

Rebased and squashed a bit. There is a rebase artifacts between commits but the final patch should be correct. Of course I'll squash further all acceptable commits before you merge this pr.

Rebased and squashed a bit. There is a rebase artifacts between commits but the final patch should be correct. Of course I'll squash further all acceptable commits before you merge this pr.
PeterSurda commented 2017-03-24 12:06:41 +01:00 (Migrated from github.com)
Copy Link

Thanks I'll look at it.

Thanks I'll look at it.
g1itch commented 2018-02-01 15:45:27 +01:00 (Migrated from github.com)
Copy Link

This is work in progress currently. Please don't merge without prior notice. The commit
9267416 has a rebase artifacts and needs to be edited in next rebase.

This is work in progress currently. Please don't merge without prior notice. The commit 9267416 has a rebase artifacts and needs to be edited in next rebase.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
enhancement
Milestone
No items
No Milestone v0.6.3
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-20#981
No description provided.
Delete Branch "l10n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?