Peter Šurda

PeterSurda commented on pull request Sysdeploy/WaitForSyncthing#1

2024-05-07 14:17:28 +00:00

syncthing sync completed or not

One more thing, we can filter the events and then the code looks nicer:

PeterSurda suggested changes for Sysdeploy/WaitForSyncthing#1

2024-05-07 14:17:28 +00:00

syncthing sync completed or not

PeterSurda commented on pull request Sysdeploy/WaitForSyncthing#1

2024-05-07 14:14:24 +00:00

syncthing sync completed or not

I think we only need GET.

PeterSurda commented on pull request Sysdeploy/WaitForSyncthing#1

2024-05-07 14:14:24 +00:00

syncthing sync completed or not

It unnecessarily queries and sleeps. I'd prefer something like this:

PeterSurda commented on pull request Sysdeploy/WaitForSyncthing#1

2024-05-07 14:14:24 +00:00

syncthing sync completed or not

Check here: 31c955c5b9/collection/plugins/module_utils/syncthing_api.py (L27)

PeterSurda suggested changes for Sysdeploy/WaitForSyncthing#1

2024-05-07 14:14:24 +00:00

syncthing sync completed or not

Overall it appears to be correct, but it could be nicer.

PeterSurda pushed to master at Bitmessage/bitmessage-js

2024-05-07 05:52:07 +00:00

7c8b28f451 Add ACK data generation into the feature matrix in readme

PeterSurda merged pull request Bitmessage/bitmessage-js#4

2024-05-07 05:52:06 +00:00

Add ACK data generation into the feature matrix in readme

PeterSurda approved Bitmessage/bitmessage-js#4

2024-05-07 05:51:57 +00:00

Add ACK data generation into the feature matrix in readme

PeterSurda approved Bitmessage/MiNode#1

2024-05-07 05:51:14 +00:00

Enable python 3.11 and resolve TLS issues

PeterSurda pushed to v0.3 at Bitmessage/MiNode

2024-05-07 05:27:33 +00:00

c9a3877b92 Lower logging level for connection error messages in I2PDialer

PeterSurda merged pull request Bitmessage/MiNode#3

2024-05-07 05:27:32 +00:00

Lower logging level for connection error messages in I2PDialer

PeterSurda approved Bitmessage/MiNode#3

2024-05-07 05:27:21 +00:00

Lower logging level for connection error messages in I2PDialer

PeterSurda pushed to master at Sysdeploy/ansible-modules-syncthing

2024-05-06 05:05:05 +00:00

31c955c5b9 Added device_defaults

PeterSurda merged pull request Sysdeploy/ansible-modules-syncthing#2

2024-05-06 05:05:03 +00:00

Added device_default

PeterSurda approved Sysdeploy/ansible-modules-syncthing#2

2024-05-06 05:04:50 +00:00

Added device_default

PeterSurda commented on pull request Sysdeploy/ansible-modules-syncthing#2

2024-05-03 03:58:25 +00:00

Added device_default

Also I would rather use device_defaults, not device_default.

PeterSurda commented on pull request Sysdeploy/ansible-modules-syncthing#2

2024-05-03 03:56:44 +00:00

Added device_default

does this work correctly on lists? e.g. allowedNetworks, igoredFolders?

PeterSurda commented on pull request Sysdeploy/ansible-modules-syncthing#2

2024-05-03 03:56:44 +00:00

Added device_default

how about

PeterSurda suggested changes for Sysdeploy/ansible-modules-syncthing#2

2024-05-03 03:56:44 +00:00

Added device_default