Peter Šurda PeterSurda
  • Joined on 2020-04-27
PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-27 16:58:57 +02:00
bd6ecc3519 Added SATA details in note
PeterSurda merged pull request Sysdeploy/idlers-agent#18 2024-06-27 16:58:55 +02:00
Added SATA details in note
PeterSurda commented on pull request Sysdeploy/idlers-agent#18 2024-06-27 16:58:50 +02:00
Added SATA details in note

There's no lsblk in Synology DSM or openwrt. You could search for /sys/block/*/device similarly as when looking for the disk sizes.

PeterSurda approved Sysdeploy/idlers-agent#18 2024-06-27 16:58:50 +02:00
Added SATA details in note

You can remove dependency on lsblk in the next PR.

PeterSurda merged pull request Sysdeploy/idlers-agent#15 2024-06-27 10:48:12 +02:00
disk space calculation using /sys/block/
PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-27 10:48:12 +02:00
54d0b0decd disk space calculation using /sys/block/
PeterSurda commented on pull request Sysdeploy/idlers-agent#15 2024-06-27 10:47:23 +02:00
disk space calculation using /sys/block/

This can be rounded up, because on systems which have 1GB of RAM, it will result in 0GB (because it subtracts the amount allocated for the kernel).

PeterSurda commented on pull request Sysdeploy/idlers-agent#15 2024-06-27 10:47:23 +02:00
disk space calculation using /sys/block/

There is a trick to make the code more readable. Use a negative condition and continue. This will reduce indentation.

PeterSurda approved Sysdeploy/idlers-agent#15 2024-06-27 10:47:23 +02:00
disk space calculation using /sys/block/

I'm merging, please address my comments in the next PR.

PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-27 00:57:59 +02:00
8f79919659 Updated ecc logic, added RAM configured speed
PeterSurda merged pull request Sysdeploy/idlers-agent#17 2024-06-27 00:57:58 +02:00
Updated ecc logic, added RAM configured speed
PeterSurda commented on pull request Sysdeploy/idlers-agent#16 2024-06-27 00:57:30 +02:00
Added note and refactor code

Yes.

PeterSurda commented on pull request Sysdeploy/idlers-agent#16 2024-06-27 00:57:12 +02:00
Added note and refactor code

It misreports on some DDR4 systems and I haven't found conclusive clarification. I have one system for example which reports TotalWidth 72 and DataWidth 72. But it doesn't influence the amount of…

PeterSurda commented on pull request Sysdeploy/idlers-agent#16 2024-06-27 00:55:12 +02:00
Added note and refactor code

Yes looks like it's ok.

PeterSurda commented on pull request Sysdeploy/idlers-agent#16 2024-06-27 00:54:46 +02:00
Added note and refactor code

one:

Handle 0x0001, DMI type 1, 27 bytes
System Information
	Manufacturer: To Be Filled By O.E.M.
	Product Name: X570D4U
	Version: To Be Filled By O.E.M.
	Serial Number: To Be Filled By…
PeterSurda pushed to main at Sysdeploy/idlers-agent 2024-06-26 01:47:21 +02:00
61909258a0 Added RAM info in notes
c5474b1f3c refactor - remove server_id from create_note_data
f10d0b53b0 minor fixes
3940cbdbde refactor: encaps create/update logic in upsert
fa67103b20 Added chachis and processor info in note
Compare 6 commits »
PeterSurda merged pull request Sysdeploy/idlers-agent#16 2024-06-26 01:47:20 +02:00
Added note and refactor code
PeterSurda commented on pull request Sysdeploy/idlers-agent#16 2024-06-26 01:46:57 +02:00
Added note and refactor code

I need to verify how it works if there are multiple processors. I have a couple of dual-socket systems, but they always have the same processor model.

PeterSurda commented on pull request Sysdeploy/idlers-agent#16 2024-06-26 01:46:57 +02:00
Added note and refactor code

I was looking at some systems, and sometimes both TotalWidth and DataWidth is 72. I'm not really sure what it means. I vaguely remember reading that that's a bug in some DDR4 modules or motherboards. For now I would only check for TotalWidth and ignore DataWidth.