citizenaspirant/PyBitmessage
1
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
1,884 Commits 3 Branches 0 Tags 13 MiB
4b559bbe66
Commit Graph

1303 Commits

Author SHA1 Message Date
Peter Surda
b202ac6fab Do not allow port 0 
Attackers injected node addresses with port 0 into the network. Port 0
is unusable on many OSes and can't be listened on. PyBitmessage won't
accept nodes that have port 0 anymore.
 2016-05-02 15:00:24 +02:00
Peter Surda
9239813ebb Constant time decryption 
Always try to decrypt with all keys.
 2016-05-02 15:00:24 +02:00
Peter Surda
4c2ce7208c Sleep on invalid getdata 
- postpone initial sleep until the first getdata is received
- also sleep when received a getdata request for an object that hasn't
been advertised to the other node yet
 2016-05-02 15:00:24 +02:00
Peter Surda
1a92db54c9 Process gateway registration rejections 
A message from gateway registration addres regarding registration
rejection is processed and a dialog displayed to get a new email
address.

Fixes #14
 2016-05-02 15:00:24 +02:00
Peter Surda
6b8f255a60 Email gateway updates 
- settings option available
- reduce max TTL to 2 days
 2016-05-02 15:00:24 +02:00
Peter Surda
2b6bffc7ff Email gateway account status query 
- addresses #14
 2016-05-02 15:00:24 +02:00
Peter Surda
db84d699db Search improvements 
- selecting a new folder will apply search
- newly arrived message will consider search
- fixes #166
 2016-05-02 15:00:24 +02:00
Peter Surda
218bdf38e1 Better error reporting for log config 
Fixes #174
 2016-05-02 15:00:24 +02:00
Peter Surda
ab974abce0 Sent message status on ACK 
Fixes #176
 2016-05-02 15:00:24 +02:00
Peter Surda
8f5d305242 Mitigate active internal intersection attack 
There was a report that by quickly asking a large number of nodes if
they have an ACK object (which the attacker knows but it is injected
into the network by the recipient of the message), it can estimate how
an object propagates through the network, and eventually pinpoint an
originating IP address of the injection, i.e. the IP address of the
message recipient.

This patch mitigates against it by stalling when asked for a nonexisting
object (so that the attacker can't spam requests), and also upon
connection before sending its own inventory list (so that reconnecting
won't help the attacker). It estimates how long a short message takes to
propagate through the network based on how many nodes are in a stream
and bases the stalling time on that. Currently that is about 15 seconds.
Initial connection delay takes into account the time that already passed
since the connection was established.

This basically gives the attacker one shot per a combination of his own
nodes and the nodes he can connect to, and thus makes the attack much
more difficult to succeed.
 2016-05-02 15:00:24 +02:00
Peter Surda
f43e01ed0e Don't send ACK on subscribed chans 
If somehow you manage to send a message that includes an ACK part into a
chan, the subscribers would send the ACK back. This shouldn't happen.
 2016-05-02 15:00:23 +02:00
Peter Surda
40f0ff381e blacklist rendering edit fix 
Editing of blacklist labels affected the rerendering, because it emits
the changed signal too, and it caused an exception because the address
field was missing at that time. This works around both.
 2016-05-02 15:00:23 +02:00
Peter Surda
0bd89103a7 Don't send unnecessary ACKs 
In some situations, it's not necessary to send an ACK. For example, when
the sender is blacklisted, when the message has no content, or when the
address has ACK sending disabled.

Also it's not necessary to rebroadcast empty messages into a mailing
list.
 2016-05-02 15:00:23 +02:00
mirrorwish
80c174e417 Save changes to blacklist labels 
Fixes mailchuck/PyBitmessage#175

Signed-off-by: Peter Surda <surda@economicsofbitcoin.com>
 2016-05-02 15:00:23 +02:00
mailchuck
bcae62938a Unused variable 2016-05-02 15:00:23 +02:00
mailchuck
24a2deed8f Cleanup lockfile on exit 
singleton.py design was broken.
Fixed Bitmessage#775
 2016-05-02 15:00:23 +02:00
mailchuck
4f26bf1059 private IP range checks 
When advertising nodes and when establishing connections, private IP
range checks were not done. This could cause private IPs to be
advertised across the network. Also, some of the checks weren't
IPv6-aware.
Fixes Bitmessage#768
 2016-05-02 15:00:23 +02:00
mailchuck
47f1c0c267 Thread names for IPv6 
Thread names for IPv6 contained ":". This caused problems in log
parsers.
 2016-05-02 15:00:23 +02:00
mailchuck
89752faceb Newly arrives messages sorting 
There could be cases where newly arrives message is not added correctly.
It won't necessarily go to the top, that depends on the sort.
 2016-05-02 15:00:23 +02:00
mailchuck
3bde549e5c Version bump for 0.5.7 2016-05-02 15:00:23 +02:00
mailchuck
185d212cb2 Unread count refresh on change 2016-05-02 15:00:23 +02:00
mailchuck
8f1e753cf0 Typo 2016-05-02 15:00:23 +02:00
mailchuck
140b3ddbb8 Test cleanup 
Safer this way
 2016-05-02 15:00:23 +02:00
mailchuck
66e1a26b33 Popup menu on folders 
There are no functions associated with it but sometimes it popped up so
disable it.
 2016-05-02 15:00:23 +02:00
mailchuck
7c99899248 updateText was deleted so no need to call it 2016-05-02 15:00:23 +02:00
mailchuck
2dc230db90 Tree rerendering cleanup 
Fixes #76
 2016-05-02 15:00:23 +02:00
mailchuck
1cc4fac7f4 Unread count cleanup 
Addresses #128
 2016-05-02 15:00:23 +02:00
mailchuck
f5187e16a0 BlackWhitelist rerendering 
It used to show entries with no address.
Fixes #170
 2016-05-02 15:00:23 +02:00
mailchuck
aae5b713b1 Disabling subscriptions should rerender addressbook 
Addresses #76
 2016-05-02 15:00:23 +02:00
mailchuck
4e4da254fa Addressbook / Tree / Messagelist rendering 
Some changes that didn't propagate correctly before now do.
Addresses #76
 2016-05-02 15:00:23 +02:00
mailchuck
f159133f14 TreeWidget and Addressbook editing propagation 
If you change, add or remove an item in a treewidget or addressbook,
messagelists will now autoupdate labels, and sender comboboxes will also
update if applicable.
Fixes #69
 2016-05-02 15:00:23 +02:00
mailchuck
e6c379cca6 Scroll/zoom in message composing widget 
Fixes #169
 2016-05-02 15:00:23 +02:00
mailchuck
a4c48228fc Messagelist subscription color 
Fixes Bitmessage#842
 2016-05-02 15:00:23 +02:00
mailchuck
484bdb0782 Quoting fixes 
Message compose sometimes misinterpreted quoted message as HTML, causing
rendering screwups. Since we don't support HTML composing, we will treat
all quoted messages as plain text.
 2016-05-02 15:00:23 +02:00
mailchuck
2597ac63f6 Zooming info percent based an single step 
Zooming in message body view / compose works in single steps
irrespective of wheel sensitivity, and info about zoom level is
displayed in percent rather than font pixel size.
 2016-05-02 15:00:23 +02:00
mailchuck
d36d6f300e Message body display handling of spaces 
After the changes in the message body renderer, spaces were not
correctly handled. Fixes #168
 2016-05-02 15:00:23 +02:00
mailchuck
056512a715 Sent folder new message selection fix 
Fixes Bitmessage#838
 2016-05-02 15:00:23 +02:00
mailchuck
9353e8eff7 Message editor updates 
- Does not allow changing fonts (it's ignored once it's sent anyway),
fixes #167
- Allows zooming, fixes #163
 2016-05-02 15:00:23 +02:00
mailchuck
32b0d24be2 singleWorker shutdown fix 
if singleWorker crashed, the thread couldn't be joined. This both makes
it so that it doesn't crash, as well as reorders the shutdown sequence
so that it is less likely to be triggered.
Fixes Bitmessage#549
 2016-05-02 15:00:23 +02:00
mailchuck
ec4a16b388 objectProcessorQueue fixes 
- it didn't shutdown correctly
- it didn't handle exception correctly (however, if I understand
correctly, this will never be triggered if using blocking get, so it
doesn't affect PyBitmessage)
- flushing size check changed from 1 to 0 (I don't know why it was 1)
 2016-05-02 15:00:23 +02:00
Peter Surda
47f0df6c0b Object processor queue class 
Previous commit didn't include the class. This class takes care of queue
size monitoring so that the system doesn't run out of memory.
 2016-05-02 15:00:23 +02:00
Peter Surda
e4f31d25fc Flood mitigation optimisation 
Flood mitigation was done both in the ObjectProcessorQueue as well as
receiveData threads. This patch removes the mitigation in receiveData
threads and cleans up the one in the ObjectProcessorQueue
 2016-05-02 15:00:23 +02:00
mailchuck
2043d796dd Typo 2016-05-02 15:00:23 +02:00
mailchuck
a0da175d45 Typo 2016-05-02 15:00:23 +02:00
mailchuck
c137e334d2 OpenSSL version for support contact form 2016-05-02 15:00:23 +02:00
mailchuck
dc34c00f38 Improve OpenSSL library finder 2016-05-02 15:00:23 +02:00
mailchuck
b7e24fab4a DLL path fix in frozen mode 
Addresses #152
 2016-05-02 15:00:23 +02:00
mailchuck
6a965cd31a Don't test for Qt in daemon mode 
Initialisation of the daemon variable was missing at launch.

Fixes #161
 2016-05-02 15:00:23 +02:00
itsexe
72f9e29931 fixed some spelling errors 2016-05-02 15:00:23 +02:00
mailchuck
98fab9c568 Message body focus on reply 
Fixes #156
 2016-05-02 15:00:23 +02:00
mailchuck
43a765515a Remember current search 
@rainulf  What's the reasoning behind resetting the search?

Fixes #155
 2016-05-02 15:00:23 +02:00
mailchuck
b699475906 Clicks in empty message shouldn't produce an error 2016-05-02 15:00:23 +02:00
mailchuck
46494dc3e6 "All accounts" can't be renamed 
Minor error
 2016-05-02 15:00:23 +02:00
mailchuck
f4c2cc5160 Unicode 
- subject on replies was not parsed correctly (or should I say was
parsed more than necessary)
- unicode can handle invalid characters without needing a special
function

Fixes #164
 2016-05-02 15:00:23 +02:00
mailchuck
962c36e122 Allow zooming of message body 
Uses default system zoom settings (Ctrl-Wheel).
Fixes #163
 2016-05-02 15:00:23 +02:00
mailchuck
4033b945ee UPnP status bar update fix 2016-05-02 15:00:23 +02:00
mailchuck
1b36da9327 Save UPnP port 
Fixes #129
 2016-05-02 15:00:23 +02:00
mailchuck
27874df45f Typo (missing) 2016-05-02 15:00:23 +02:00
mailchuck
3f2108b36f Typo 2016-05-02 15:00:23 +02:00
mailchuck
e5675987a7 Fix frozen localisation (OSX) 
Fixes Bitmessage#737
 2016-05-02 15:00:23 +02:00
mailchuck
d7ff86705e Fix frozen localisation 
Addresses Bitmessage#737
 2016-05-02 15:00:23 +02:00
mailchuck
6f74ffc265 Mac OSX portable mode path 
Fixes #150
 2016-05-02 15:00:23 +02:00
mailchuck
3b30afea29 Messagelist subject class 
Messagelist subjects now are their own class. Fixes #153
Also fixes replies/clipboard for gatewayed messages.
 2016-05-02 15:00:22 +02:00
mailchuck
d6ec2a2b8d Version bump 2016-05-02 15:00:22 +02:00
mailchuck
0f24fe5a0c Missing import 2016-05-02 15:00:22 +02:00
mailchuck
4647fcb876 Disable label rerendering in messagelist 
It's broken and just consumes resources. I'll fix it separately.
 2016-05-02 15:00:22 +02:00
mailchuck
e650cff42d (Un)read messagelist items 
Previous commits broke them, now it renders correctly again.
 2016-05-02 15:00:22 +02:00
mailchuck
4b63c4c086 Address Qt.UserData fix 
The previous commit broke places where UserData was read from the
mesagelist line, because it's now a string rather than a QVariant. This
actually simplifies things.
 2016-05-02 15:00:22 +02:00
mailchuck
879a6f1d68 Messagelist loads faster 
Addresses #149. About 5 times faster.
 2016-05-02 15:00:22 +02:00
mailchuck
0b4c57a516 Entries missing in messagelist 2016-05-02 15:00:22 +02:00
mailchuck
a8053195ea Fix cdecl/stdcall DLL detection 
Fixes #146
 2016-05-02 15:00:22 +02:00
Peter Surda
69494594d5 Main Window raising fixes 
On OSX and linux, the tray icon now raises window.

Starting a new instance should raise the window too, but it may not work
on linux (on my Ubuntu it just flashes the icon)

Fixes Bitmessage#743
 2016-05-02 15:00:22 +02:00
mailchuck
ff207c1b56 Portable mode fix 
The option should not be available if the directory with the executable
is not writable, such as when running from a dmg on OSX.
 2016-05-02 15:00:22 +02:00
mailchuck
4dbd444053 Logging fix 2016-05-02 15:00:22 +02:00
mailchuck
ea37913ff1 Html parser fixes 
Raw mode improved, avoid HTML parser entirely and just replaces some
strings.
 2016-05-02 15:00:22 +02:00
mailchuck
07cee7209b Contact support fixes 
- typos & formatting
- OS detection crash fixes
 2016-05-02 15:00:22 +02:00
Peter Surda
d0b9d75ce1 Fix contact support unix detection 2016-05-02 15:00:22 +02:00
mailchuck
4049662a3a Contact support updates 
Yes/No -> True/False
Add Portable mode
 2016-05-02 15:00:22 +02:00
mailchuck
3e956509b2 Add PyBitmessage version to contact support 2016-05-02 15:00:22 +02:00
mailchuck
8359b8b202 Contact support user interface 
Fixes #25
 2016-05-02 15:00:22 +02:00
mailchuck
a727847e55 Addresses can be configured not to send acks 
Manually by specifying "dontsendack" = true in the address section
 2016-05-02 15:00:22 +02:00
mailchuck
4c8ba431e5 Add to blacklist from "All accounts" 
It didn't work before
 2016-05-02 15:00:22 +02:00
mailchuck
17d045da10 Sensible default maximum difficulty 
Fixes #144
 2016-05-02 15:00:22 +02:00
mailchuck
1f525da1ff Link follow warning 
The message box should be a warning rather than a simple question.
 2016-05-02 15:00:22 +02:00
mailchuck
eb35f35b83 Add system translations 
Items like dialog box buttons were not localised. This loads the default
qt localisation, and also unloads the old localisation on locale change.
Still needs to be adjusted for frozen.

Addresses Bitmessage#737
 2016-05-02 15:00:22 +02:00
mailchuck
7ef94b446d Lazy rendering of message contents 
Message will render as user is scrolling down. This prevents interface
freezes on long messages (such as inline img in text mode). Fixes
Bitmessage##366

Also a minor fix in text mode rendering.
 2016-05-02 15:00:22 +02:00
mailchuck
6557681a6c Message has safe link opening 
Links in message body (if in HTML mode) now open, but it asks for a
confirmation in a dialog box.

Fixes #27
 2016-05-02 15:00:22 +02:00
mailchuck
751f9108d8 HTML detector and switcher 
HTML messages are detected and if present, the top of the message
textedit displays a clickable area that switches HTML rendering on and
off.

Fixes #13
 2016-05-02 15:00:22 +02:00
mailchuck
8ff5bf0464 Channel reply enhancement 
When replying to a message sent to a chan, now you can choose if you
want to reply to chan or sender. Fixed #9
 2016-05-02 15:00:22 +02:00
mailchuck
4e32125ca3 Copy to clipboard in messagelists 
Fixes #142
 2016-05-02 15:00:22 +02:00
mailchuck
e2fb34e2fb More portable mode fixes 2016-05-02 15:00:22 +02:00
mailchuck
242c8fa9c2 More portable mode fixes 2016-05-02 15:00:22 +02:00
mailchuck
8136b022bc Typos 
Still regarding portable mode path fixes
 2016-05-02 15:00:22 +02:00
mailchuck
5a45d7dd8f Portable mode fixes 
Fixes Bitmessage#379, Bitmessage#341
 2016-05-02 15:00:22 +02:00
mailchuck
4f6fd07424 Joining chans interface freeze 
Fixes #137
 2016-05-02 15:00:22 +02:00
Peter Surda
538642f236 Label for blacklisting sender fix 
It wasn't properly utf-8-ied.
 2016-05-02 15:00:22 +02:00
Peter Surda
bdfaa90ecb Auto-register for email gateway if necessary 
If attempting to send to an email address from an unregistered
account, auto-send registration to mailchuck.
Use label if possible, otherwise random 12 characater address

Fixes #131
 2016-05-02 15:00:22 +02:00
Peter Surda
082eb823bb New message appears if viewing account root 
Fixes #132
 2016-05-02 15:00:22 +02:00
mailchuck
d72e5647f4 Fix wrong account type initialiser 
Addresses #14
 2016-05-02 15:00:22 +02:00
mailchuck
27b8891ab4 Test commit policy commit 2016-05-02 15:00:22 +02:00
mailchuck
a5456f792c Fix Addressbook context menu delete 2016-05-02 15:00:22 +02:00
mailchuck
41ac1b89d1 Frozen SMP re-disable try 2 2016-05-02 15:00:22 +02:00
mailchuck
549d91dc68 Re-disable windows SMP frozen support 
The recommended workaround didn't work.
 2016-05-02 15:00:22 +02:00
mailchuck
1625306be3 Version bump 2016-05-02 15:00:22 +02:00
mailchuck
bccc2406a2 Fix double unread count in tray icon 2016-05-02 15:00:22 +02:00
mailchuck
d54b22bb89 Initialise inventorySets earlier 
In corner cases, they may be referenced before they are populated.
Probably fixes Bitmessage#530
 2016-05-02 15:00:22 +02:00
mailchuck
52fe7105a9 Allow bootstrap from a Tor hidden service 
I run a modified node as a Tor hidden service for bootstrapping node
addresses, and PyBitmessage can now connect to it.
 2016-05-02 15:00:22 +02:00
mailchuck
27c187283b Unify messagelist rendering 
also some minor fixes
 2016-05-02 15:00:22 +02:00
mailchuck
a3b13b70e2 Add BROADCAST type 
also improve sorting
 2016-05-02 15:00:22 +02:00
mailchuck
be02116af9 Global folder, global search, unread folder 
Fixes #38
Fixes #39

Minor unread refresh issues.
 2016-05-02 15:00:22 +02:00
mailchuck
6862952c55 Typo 
OpenCL config variable setter had a typo
 2016-05-02 15:00:22 +02:00
mailchuck
6ad3c956c9 Allow SQL arguments as a list or tuple 2016-05-02 15:00:21 +02:00
mailchuck
d75533c6b6 DNS bootstrap over Tor 
If proxy type is SOCKS5, it will try to perform DNS bootstrap using the
Tor RESOLVE extension.
 2016-05-02 15:00:21 +02:00
mailchuck
1e89616c0f Avoid strings in account types 2016-05-02 15:00:21 +02:00
mailchuck
399100e6d8 PoW support code cleanup 
Is now nicer and reports if OpenCL fails
 2016-05-02 15:00:21 +02:00
mailchuck
9335f74c61 OpenCL kernel change 
This makes it work on my AMD.
 2016-05-02 15:00:21 +02:00
mailchuck
e7e245fe25 OpenCL GUI settings 2016-05-02 15:00:21 +02:00
mailchuck
0c19e0c2e4 Failure to connect shouln't be an error 
It resulted in too many errors in the logs
 2016-05-02 15:00:21 +02:00
mailchuck
d0b73eb211 SMP fix for frozen Windows 2016-05-02 15:00:21 +02:00
mailchuck
aa97b53114 addressGenerator fixes 
- addressGenerator got stuck (introduced recently when cleaning up
shutdown
- do not put addresses into API return queue if API is inactive
- improve translation
 2016-05-02 15:00:21 +02:00
mailchuck
f9a7a5b6f2 Account in treeWidget more like a QT class 
It behaves more like a QT class is supposed to now, it's somewhat
cleaner.
Fixes #122
 2016-05-02 15:00:21 +02:00
mailchuck
d69c2e097f Cleaner shutdown 
Addresses Bitmessage#549
 2016-05-02 15:00:21 +02:00
mailchuck
6dbe20a25c Version bump 2016-05-02 15:00:21 +02:00
mailchuck
7b4264a109 Typo 2016-05-02 15:00:21 +02:00
mailchuck
f77afe8fae Exception handling 2016-05-02 15:00:21 +02:00
mailchuck
36ddbd365e Typo 2016-05-02 15:00:21 +02:00
mailchuck
410c23e8c0 Typo 2016-05-02 15:00:21 +02:00
mailchuck
ff358b1a1f Typo 2016-05-02 15:00:21 +02:00
mailchuck
ec68146135 Suppress error on releasing unlocked lock 2016-05-02 15:00:21 +02:00
mailchuck
e82e33fa51 UPnP notifications 
UPnP will notify you through window status bar.
 2016-05-02 15:00:21 +02:00
mailchuck
bbdfb1ea54 UPnP cleaner shutdown 2016-05-02 15:00:21 +02:00
mailchuck
e4a7e71790 SSL fixes 2016-05-02 15:00:21 +02:00
mailchuck
281630757e SSL fixes 2016-05-02 15:00:21 +02:00
mailchuck
18f7ef06e2 SSL fixes 
Handle old Python compatibility better.
 2016-05-02 15:00:21 +02:00
mailchuck
74519069f0 outgoingSynSender thread reaping disabled 
It was causing delays on shutdown, worse on linux/osx
 2016-05-02 15:00:21 +02:00
mailchuck
b00c4f24ec Threads close better 
- UPnP and outgoingSynSender threads close slightly better.
- extPort initialisation was missing
 2016-05-02 15:00:21 +02:00
mailchuck
48b9e50397 UPnP GUI 
Settings GUI now contains a checkbox for UPnP and auto starts/stops the
thread when changed.
Default UPnP socket timeout decreased for faster thread
starting/stopping
 2016-05-02 15:00:21 +02:00
mailchuck
50be5a2b4c UPnP fixes 2016-05-02 15:00:21 +02:00
mailchuck
8c14641810 Window resize on minimize bugfix 
Fixes Bitmessage#243
 2016-05-02 15:00:21 +02:00
mailchuck
c03c563a74 Make UPnP into a thread 
- UPnP is now a separate thread that will continue to setup UPnP
- shutdown waits for threads that shutdown correctly (Addresses
Bitmessage#549)
 2016-05-02 15:00:21 +02:00
mailchuck
cc848cdb65 Typo fix 2016-05-02 15:00:21 +02:00
mailchuck
5432c6e0c8 UPnP logging improvlement 2016-05-02 15:00:21 +02:00
mailchuck
3c9df7151c Logging fix 2016-05-02 15:00:21 +02:00
mailchuck
aa55f45a0d Logging fix 2016-05-02 15:00:21 +02:00
Peter Surda
0270dc3d4d Cleanup UPnP 2016-05-02 15:00:21 +02:00
mailchuck
9338772b1e Logging updates 
Came over BM (from "general" channel), I slightly modified it.
 2016-05-02 15:00:21 +02:00
mailchuck
b7ad34cf15 Trusted peer flood protection 
Is not needed.
Fixed Bitmessage#786
 2016-05-02 15:00:21 +02:00
mailchuck
960d446104 Ask before deleting a subscription 
Fixes #120
 2016-05-02 15:00:21 +02:00
mailchuck
c2970cd92e Update addressbook on changes 
Fixes  #99
- enable/disable new/delete chan/subscription
- also found and fixed a logger crash
 2016-05-02 15:00:21 +02:00
mailchuck
1f331f217c Messagelist address tooltip 
Fixes #108
 2016-05-02 15:00:21 +02:00